Victor Stinner writes: > Le jeu. 19 mars 2020 à 02:17, Kyle Stanley <aeros...@gmail.com> a écrit : > > Agreed; a PEP (even if it's just informational) would go a long way in > > helping to clear up some misunderstandings. > > I am still moving blindly in the darkness of CPython internals and so > I don't feel comfortable to write a PEP which would mean that I know > what I am doing :-)
That's OK, you're not Dutch. :-) Or are you? :-) :-) > So far, I have no strong opinion about passing explicitly tstate vs > "implicit" TLS (Thread Local Storage) variable. I mean, I don't feel > that I have enough feedback to see which option is the best. > > All I can say is that passing explicitly tstate helps me to validate > that the code is *correct*. It helps me to understand where tstate > comes from and helps me to understand if tstate is valid or not. That makes a lot of sense, as a strategy for doing the work. It should be pretty straightforward to convert the tstate argument to a thread-local tstate. But ... this sounds to me like work that should be done on a branch. I'm sure you considered that, but I also expect others will feel the same way. Perhaps this is a good opportunity to document why it's not being done on a branch. > There are still too many functions which don't work properly with > subinterpreters. There are still a few design issues that needs to > be addressed. Are subinterpreters in use in production? If so, and especially if these use cases are unpatched vs. master, that would be justification for pushing to master since you are clearly fixing problems with subinterpreter use. If not, I still tend to think this work should be on a branch, at least until the tstate argument vs. thread-local tstate question is resolved. I realize that these are all abstract arguments in favor of work on a branch. I think it would be useful if you could provide concrete reasons why work on master is a better way to proceed. I wouldn't be surprised if some of the examples of bugs and improvements you've already given would be involved, and I just don't understand the implications without explanation. Regards, Steve _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/ME4THCDACUA6PFV2MOGIJEHZOGF6DT2F/ Code of Conduct: http://python.org/psf/codeofconduct/
