On 17/08/2020 1:13 pm, Henk-Jaap Wagenaar wrote:
On Mon, 17 Aug 2020 at 11:30, Mark Shannon <m...@hotpy.org <mailto:m...@hotpy.org>> wrote:


    I would also bring you attention to my rigorous analysis of the
    possible
    application to PEP 622 the entirety of CPython.
    If I have made any mistakes there, I'd be happy to correct them.


You say "I've elided a lot of complex logic int cases, as it is not relevant." in the plistlib._BinaryPlistWriter._write_object example, this seems to be a prime example where guards could be used to simplify/unnest the logic? Even if you disagree, I think it is highly relevant and worth commenting on, one way or another!

Thanks for the feedback.

I've expanded the code in the `int` and `UID` cases, and made it clearer why the remaining code has been elided.


Cheers,
Mark.
_______________________________________________
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/WMLES4ER52GGJCXQTH2ULSF5EESCXVHY/
Code of Conduct: http://python.org/psf/codeofconduct/

Reply via email to