Hello, I am trying to sort out what can be done for bpo-35753 /
https://github.com/python/cpython/pull/22981
Basically any module that does "from unittest.mock import call" will
crash the doctest scanner.
At this point I'm not sure how to proceed at this point, there is some
different ideas on how to fix it, I guess I could try to fix this
differently, however I am a little worried that the different fix
suggested in the PR will be higher risk, that said if folks would be up
for reviewing this change I would give it a shot to code it up.
Can't tell right now if there's no interest in reviewing this patch
because there is a feeling that it should be done differently, or just
lack of interest in doctest.
Can I get clued in on what is the best way forward? I am happy to redo
patch, but unsure there is enough interest in this problem for an
alternative patch to be reviewed.
thanks,
-Alfred
-------- Forwarded Message --------
Subject: [Python-Dev] minor PR 22981 waiting review ~20 days:
https://github.com/python/cpython/pull/22981
Date: Mon, 14 Dec 2020 13:25:36 -0800
From: Alfred Perlstein <alf...@freebsd.org>
Organization: FreeBSD
To: Python Dev <python-dev@python.org>
PR 22981 is a minor update to doctest to allow it to safely consume
modules which contain objects that cause inspect.unwrap to throw.
I believe the review comments in the PR have been addressed at this
point for ~20 days. The patch is relatively small, reviews are done,
but it is unmerged.
Is there a way to "bump" the request for review?
thank you,
-Alfred
_______________________________________________
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at
https://mail.python.org/archives/list/python-dev@python.org/message/2YFKPBDFX3Q53PMDNWAV3ZKCSTSVZJXJ/
Code of Conduct: http://python.org/psf/codeofconduct/
_______________________________________________
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at
https://mail.python.org/archives/list/python-dev@python.org/message/C24MPE5NUGMIDLLABR7AUONWAZOI5EWH/
Code of Conduct: http://python.org/psf/codeofconduct/
