On Fri, Mar 19, 2021 at 9:29 AM Faisal Mahmood <fasial.mahmoo...@gmail.com> wrote:
> Hello, > > Following my previous e-mail last month, thank you for responding. I > almost immediately got two reviewers who posted helpful comments on my PR > which I believe have all been resolved now. > > Today, I got a notification to say my branch is stale again so wanted to > understand what the next steps are. > > Is there anything else I can do to get my PR merged? This is my first time > submitting a PR to Cpython so not sure of the workflow, or if I have missed > something so would appreciate your guidance. > At this point it's up to a core dev to have the time and inclination to look at the PR and either give feedback or to merge it (unfortunately I personally lack the knowledge to help out with this PR). -Brett > > SIDE QUESTION: Also, when I originally submitted this PR, I used a > different Git config and user called "KillerKode" - however I was asked to > change this, which is totally understandable so I changed everything to my > name, however the commit history of that PR now contains some commits from > my old Git config (as KillerKode) and some with my new Git config (as > Faisal Mahmood). I am wondering, when this gets merged, how can I make > sure that the commits are squashed and any history of my previous git > config (i.e. KillerKode) do not show? > > Kind regards, > > Faisal. > > On Mon, 15 Feb 2021 at 14:20, Faisal Mahmood <fasial.mahmoo...@gmail.com> > wrote: > >> Hello, >> >> I hope you are all well, I currently have an issue / merge request that >> has become stale and as per the guidelines I am sending this e-mail to >> request someone to review it for me please. >> >> Issue Number: 42861 (https://bugs.python.org/issue42861) >> Pull Request: 24180 (https://github.com/python/cpython/pull/24180) >> >> This is my first contribution to CPython and I am very keen to get this >> added as I think it is an almost essential enhancement missing from the >> ipaddress module. I would greatly appreciate if someone can take a look >> and give me feedback, I am more than happy to help explain things, as I >> appreciate this is not the most straightforward thing to do. >> >> Effectively, this method allows you to get the next closest network of >> any prefix size, it works by effectively adding 1 to the host portion of >> the network. There is actually a very nice guide someone made on >> stackexchange explaining how to do this calculation manually, I simply >> followed this logic and have tested it as much as possible and it seems to >> work great. See here: >> https://networkengineering.stackexchange.com/questions/7106/how-do-you-calculate-the-prefix-network-subnet-and-host-numbers/53994#53994 >> >> Please let me know if there is anything else I can do to help get this >> merged. >> >> Kind regards, >> >> Faisal. >> > _______________________________________________ > Python-Dev mailing list -- python-dev@python.org > To unsubscribe send an email to python-dev-le...@python.org > https://mail.python.org/mailman3/lists/python-dev.python.org/ > Message archived at > https://mail.python.org/archives/list/python-dev@python.org/message/DUL55S2S5C5AJO33LAPSL7MAOI5Y76WV/ > Code of Conduct: http://python.org/psf/codeofconduct/ >
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/7IOSA6ALD42A6SDQX2525UCBTNYTGT2X/ Code of Conduct: http://python.org/psf/codeofconduct/
