Before looking at the code, my first question would be about the description: "I kinda ran out of time, i suspect more testing is due."
If you were out of time then it's probably not done and maybe lacks the tests you initially thought it did, so did you find the time and/or is the PR done? On Tue, Jul 6, 2021 at 10:07 AM Yair Frid <fridy...@gmail.com> wrote: > Hello, a few months ago i created this PR: > https://github.com/python/cpython/pull/24181 > Which has since gone stale, I would really like it to be reviewed before i > continue fixing other issues as i do not want to have to deal with a > backlog of PRs > Thanks in advance, Yair. > _______________________________________________ > Python-Dev mailing list -- python-dev@python.org > To unsubscribe send an email to python-dev-le...@python.org > https://mail.python.org/mailman3/lists/python-dev.python.org/ > Message archived at > https://mail.python.org/archives/list/python-dev@python.org/message/TYZH5DQJUBRMEPAR5N2I5VDGHNG7Y6SU/ > Code of Conduct: http://python.org/psf/codeofconduct/ >
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/PQSY3JH7VVAWUMFAODZ3KAIXQFPP4VVB/ Code of Conduct: http://python.org/psf/codeofconduct/
