> On 4 Aug 2021, at 11:48, Miro Hrončok <mhron...@redhat.com> wrote: > > On 04. 08. 21 11:28, Petr Viktorin wrote: >> Hi, >> A recent change "make html" in the Doc directory create a venv if one wasn't >> there before. If you don't want to download sphinx and other dependencies >> from PyPI, you'll need to adjust your workflow. >> If you already have all the dependencies, the following command (in the >> CPython directory, not Doc) will build docs for you: >> sphinx-build Doc Doc/build/ >> The issue that added this is: https://bugs.python.org/issue44756 > > For what it's worth, I think that: > > - changes in the workflow should be discussed first > - changes like this should not happen this late in the release cycle > - a documented/supported way to build the docs with make without venv should > exist (currently, running `mkdir venv` before `make ...` kinda works)
Sorry for the disruption, I approved the change. I didn't realize skipping the `venv` altogether was a viable build option and I've been making releases with docs for over two years now. For me this change was mostly a matter of convenience. If the current state is undesirable for downstream distributors, I can revert `make build` being explicitly dependent on `make venv`. Regardless of that, for future build-related changes I'll make sure to loop more people in. - Ł
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/HLCY75WB6ZOJNU6DUNLUMTQSHMYFGNER/ Code of Conduct: http://python.org/psf/codeofconduct/