So you're proposing to completely get rid of those three? And you're sure that each and every single call to any of those is better off being an assert()?
(I still haven't gotten into the habit of building in debug mode by default, in part because it *isn't* the default when you invoke ./configure or PCbuild/build.bat.) On Mon, Feb 7, 2022 at 8:45 AM Victor Stinner <[email protected]> wrote: > On Mon, Feb 7, 2022 at 5:38 PM Guido van Rossum <[email protected]> wrote: > > ISTM this is better discussed on a case-by-case basis than as a blanket > policy change. (The latter could end up causing a flood of trivial PRs from > wannabe-contributors who found and fix yet another violation of the policy, > which is both a nuisance for reviewers and a risk of introducing bugs due > to being over-zealous.) > > That's why I propose to only change code using these 3 functions: > > * PyErr_BadInternalCall(), > * _Py_CheckFunctionResult() > * _Py_CheckSlotResult() > > Victor > -- > Night gathers, and now my watch begins. It shall not end until my death. > -- --Guido van Rossum (python.org/~guido) *Pronouns: he/him **(why is my pronoun here?)* <http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-change-the-world/>
_______________________________________________ Python-Dev mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/MGVQ4EAXBH7EYZB27Z3TGT3IUU4IU6GK/ Code of Conduct: http://python.org/psf/codeofconduct/
