Tim Peters wrote:
> #if THREAD_STACK_MIN < PTHREAD_STACK_MIN
>
> assumes that the expansion of PTHREAD_STACK_MIN acts like a
> compile-time constant expression, but there's no such guarantee.
>
> http://cvs.opensolaris.org/source/xref/on/usr/src/head/limits.h
>
> shows that, on one version of Solaris, it's actually defined via
>
> #define PTHREAD_STACK_MIN ((size_t)_sysconf(_SC_THREAD_STACK_MIN))
>
> That has a runtime value, but not a useful compile-time value. The
> only useful thing you can do with it in an #if expression is
> defined(PTHREAD_STACK_MIN).
Ok.
>> 2. I don't know what to make of the failure of test_threading on Linux,
>> as test_thread succeeds as far as I could see. These tests succeed on my
>> FreeBSD box and also appear to be succeeding on the Windows buildbots.
>
> Not all pthreads-using builds fail, and not all failing pthreads-using
> builds fail in the same way. Welcome to pthreads on Linux ;-)
>
> BTW, this sucks:
>
> test_thread
> /home/buildbot/Buildbot/trunk.baxter-ubuntu/build/Lib/test/test_thread.py:138:
>
>
> RuntimeWarning: thread stack size of 0x1000 bytes not supported
> thread.stack_size(tss)
>
> That's from a successful run. RuntimeWarning really doesn't make
> sense for a failing operation. This should raise an exception
> (xyzError, not xyzWarning), or a failing stack_size() should return an
> error value after ensuring the original stack size is still in effect.
Fair enough.
{...}
> If PyThread_start_new_thread() fails in any way
> (like,pthread_attr_setstacksize() failing), ""can't start new thread"
> is the error we see.
>
> The difference between test_thread and test_threading here is that
> only test_threading asks for a 16MB stack; test_thread doesn't ask for
> a stack larger than 4MB.
Thanks for the analysis!
> Until all this gets resolved, I strongly suggest reverting this patch
> (if you don't, someone else will ...) and hammering out the problems
> on a new branch instead. See python-dev email from yesterday for how
> to force a buildbot slave to build a branch.
I see that you've already reverted this - Thanks & sorry I couldn't get
to it quickly.
Regards,
Andrew.
-------------------------------------------------------------------------
Andrew I MacIntyre "These thoughts are mine alone..."
E-mail: [EMAIL PROTECTED] (pref) | Snail: PO Box 370
[EMAIL PROTECTED] (alt) | Belconnen ACT 2616
Web: http://www.andymac.org/ | Australia
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
