Walter Dörwald wrote: >>> The best way to throughly test the patch is of course to check it in. ;) >> Is it too risky? ;) > > At least I'd like to get a second review of the patch.
I've reviewed it, and am likely to check it in. I notice that the patch still has problems. In particular, it is limited to "DBCS" (and SBCS) character sets in the strict sense; general "MBCS" character sets are not supported. There are a few of these, most notably the ISO-2022 ones, UTF-8, and GB18030 (can't be bothered to look up the code page numbers for them right now). What I don't know is whether any Windows locale uses a "true" MBCS character set as its "ANSI" code page. The approach taken in the patch could be extended to GB18030 and UTF-8 in principle, but can't possibly work for ISO-2022. Regards, Martin _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
