>> In abstract.c, there are many error messages like
>>
>> type_error("object does not support item assignment");
>>
>> It helps debugging if the object's type was prepended.
>> Should I go through the code and try to enhance them
>> where possible?
>
> So that's definite "perhaps"?
>
> Anyway, posted patch 1507676.

Sigh. I guess I'll have to commit it to get a second (actually,
third, thanks Armin) opinion...


If you want an opinion on whether it is useful, then yes, it is useful.  Honestly I thought that was kind of obvious since better, more informative error messages are always better as long as the verbosity is not insane.

As for looking at the patch, that is just the usual time/priority problem.  =)

Also, be sure to pay attention to speed when it comes to exceptions that are both generated and caught internally -- those need to remain as fast and lightweight as possible (not spending time inside sprintf() and the like).  Grep for PyErr_ExceptionMatches to get a feel for which should treated with care.   Please do not mindlessly go through and change all the exception messaging.  Instead, devote some thought to which messages are detrimentally uninformative and are not part of time critical execution paths.


Raymond
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Reply via email to