[Tim] > I just noticed that the bsddb portion of Python fails to compile on > the 2.4 Windows buildbots, but for some reason the buildbot machinery > doesn't notice the failure:
But it does now. This is the revision that broke the Windows build: """ r52170 | andrew.kuchling | 2006-10-05 14:49:36 -0400 (Thu, 05 Oct 2006) | 12 lines [Backport r50783 | neal.norwitz. The bytes_left code is complicated, but looks correct on a casual inspection and hasn't been modified in the trunk. Does anyone want to review further?] Ensure we don't write beyond errText. I think I got this right, but it definitely could use some review to ensure I'm not off by one and there's no possible overflow/wrap-around of bytes_left. Reported by Klocwork #1. Fix a problem if there is a failure allocating self->db. Found with failmalloc. """ It introduces uses of assert() and strncat(), and the linker can't resolve them. I suppose that's because the Windows link step for the _bsddb subproject explicitly excludes msvcrt (in the release build) and msvcrtd (in the debug build), but I don't know why that's done. OTOH, we got a lot more errors (about duplicate code definitions) if the standard MS libraries aren't explicitly excluded, so that's no fix. _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
