Ralf, Terry is right. Please file a bug. I do think there may be a problem with that change but I don't have the time to review it in depth. Hopefully others will. I do recall that sockets reading one byte at a time has been a problem before -- I recall a bug about this in the 1.5.2 era for Windows... Too bad it's back. :-(
--Guido On Mon, Apr 14, 2008 at 10:25 AM, Terry Reedy <[EMAIL PROTECTED]> wrote: > > "Ralf Schmitt" <[EMAIL PROTECTED]> wrote in message > news:[EMAIL PROTECTED] > > > | Hi all, > | > | I'm using mercurial with the release25-maint branch. I noticed that > checking > | out a local repository now takes more than > | 5 minutes (it should be around 30s). > | > | I've tracked it down to this change: > | http://hgpy.de/py/release25-maint/rev/e9446c6ab3cd > | this is svn revision 61009. Here is the diff inline: > | > | --- a/Lib/socket.py Fri Mar 23 14:27:29 2007 +0100 > | +++ b/Lib/socket.py Sat Feb 23 20:30:59 2008 +0100 > | @@ -305,7 +305,7 @@ > | self._rbuf = "" > | while True: > | left = size - buf_len > | - recv_size = max(self._rbufsize, left) > | + recv_size = min(self._rbufsize, left) > | data = self._sock.recv(recv_size) > | if not data: > | break > | > | > | > | self._rbufsize if 1, and so the code reads one byte at a time. this is > | clearly wrong, I'm posting it to the mailing list, as I don't want > | this issue to get lost in the bugtracker. > > > -------------------------------------------------------------------------------- > > It is at least as likely to get lost here. There is a mailing list for new > tracker items that many devs subscribe to. > > > > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > http://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > http://mail.python.org/mailman/options/python-dev/guido%40python.org > -- --Guido van Rossum (home page: http://www.python.org/~guido/) _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
