On Tue, Apr 22, 2008 at 1:56 AM, Tarek Ziadé <[EMAIL PROTECTED]> wrote: > On Mon, Apr 21, 2008 at 2:25 AM, Steven Bethard <[EMAIL PROTECTED]> wrote: > > On Sun, Apr 20, 2008 at 4:15 PM, Tarek Ziadé <[EMAIL PROTECTED]> wrote: > > > I have submitted a patch for review here: > http://bugs.python.org/issue2663 > > > > > > glob-style patterns or a callable (for complex cases) can be provided > > > to filter out files or directories. > > > > I'm not a big fan of the sequence-or-callable argument. Why not just > > make it a callable argument, and supply a utility function so that you > > can write something like:: > > > > exclude_func = shutil.excluding_patterns('*.tmp', 'test_dir2') > > shutil.copytree(src_dir, dst_dir, exclude=exclude_func) > > I made another draft based on a single callable argument to try out: > http://bugs.python.org/file10073/shutil.copytree.filtering.patch > > The callable takes the src directory + its content as a list, and > returns filter eligible for exclusion
FWIW, that looks better to me. > That makes me wonder, like Alexander said on the bug tracker: > In the glob-style patterns callable, do we want to deal with absolute paths ? I think that it would be okay to document that shutil.ignore_patterns() only accepts patterns matching individual filenames (not complex paths). If someone needs to do something with absolute paths, then they can write their own 'ignore' function, right? Steve -- I'm not *in*-sane. Indeed, I am so far *out* of sane that you appear a tiny blip on the distant coast of sanity. --- Bucky Katt, Get Fuzzy _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
