On Fri, Oct 29, 2010 at 10:38 AM, victor.stinner
<python-check...@python.org> wrote:
> try:
> - path_list = env.get('PATH')
> + # ignore BytesWarning warning
> + with warnings.catch_warnings(record=True):
> + path_list = env.get('PATH')
This looks odd to me. You're requesting that the warnings be saved,
but not actually retrieving the list object where they're recorded
from the __enter__ method.
The correct way to suppress a specific warning type is:
with warnings.catch_warnings():
warnings.simplefilter("ignore", BytesWarning)
path_list = env.get('PATH')
I'll also echo Benjamin's concern with the embedded import. Of such
things, deadlocks are created. If there's a dependency problem between
os and the warnings build process in a fresh build, then it is better
to simply fix that rather than risking the deadlock.
Cheers,
Nick.
--
Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
