On 10/31/2010 1:44 PM, Antoine Pitrou wrote:
On Sun, 31 Oct 2010 18:15:43 +0100 (CET) benjamin.peterson<python-check...@python.org> wrote:# SimSMTPChannel doesn't fully support LOGIN or CRAM-MD5 auth because they # require a synchronous read to obtain the credentials...so instead smtpd @@ -503,6 +504,7 @@ except smtplib.SMTPAuthenticationError as err: if sim_auth_login_password not in str(err): raise "expected encoded password not found in error message" + smtp.close()Perhaps the string-raising above should be converted to 3.x-compliant code?
Since raise 'string' itself raises a TypeError in 3.x, it must be that the raise statement has never been executed in 3.x testing or that the TypeError has not been noticed to be an erroneous error.
def testAUTH_CRAM_MD5(self): self.serv.add_feature("AUTH CRAM-MD5") @@ -512,6 +514,7 @@ except smtplib.SMTPAuthenticationError as err: if sim_auth_credentials['cram-md5'] not in str(err): raise "expected encoded credentials not found in error message" + smtp.close()Same here.
-- Terry Jan Reedy _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
