On Fri, 2011-02-25 at 18:32 +0100, Antoine Pitrou wrote: > On Fri, 25 Feb 2011 15:39:16 +0100 (CET) > giampaolo.rodola <python-check...@python.org> wrote: > > > +#else > > + *((off_t*)addr) = PyLong_Check(arg) ? PyLong_AsLongLong(arg) > > + : PyLong_AsLong(arg); > > +#endif > > There's something fishy here. Why would you call PyLong_AsLong() if > PyLong_Check() is false? >
I'm not entirely sure how that works (other than it seems to!). The code came from other places where large file support is, such as in ftruncate() and lseek() in the posix module. Ross > > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > http://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > http://mail.python.org/mailman/options/python-dev/rosslagerwall%40gmail.com _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
