On Fri, Mar 4, 2011 at 5:52 PM, Barry Warsaw <ba...@python.org> wrote: > On Mar 04, 2011, at 05:19 PM, Victor Stinner wrote: > >>Le vendredi 04 mars 2011 à 10:05 -0600, s...@pobox.com a écrit : >>> Is Rietveld or Review Board being used within the Python core development >>> community? I looked at the dev guide but didn't see anything obvious about >>> code reviews. I don't see how to search the Rietveld instance at >>> codereview.appspot.com looking just for Python core review requests. >>> >>> My aim here is to provide some examples to a colleague at work. I wanted to >>> give him some examples related to code with which I'm familiar. >> >>I used it at least twice. >> >>Issue #9425: http://codereview.appspot.com/1874048 >>Issue #3080: http://codereview.appspot.com/3972045 > > Yep, I used Rietveld for the PEP 3147/3149 patches and it was pretty nice. > It's not completely well integrated into our workflow, but it's cool enough > that I think we should promote it more. Will that be easier once we're > permanently on Mercurial?
FWIW there's a nice section in the contribution guidelines for the Go language about code reviews and how they integrate Rietveld into their development process: http://golang.org/doc/contribute.html#Code_review They're using a wrapper around the upload.py script bundled as a Mercurial extension. And IIRC there's already some Roundup integration done. -Andi > > -Barry > > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > http://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > http://mail.python.org/mailman/options/python-dev/albrecht.andi%40googlemail.com > > _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
