On Thu, 05 May 2011 20:38:27 +0200 raymond.hettinger <python-check...@python.org> wrote: > http://hg.python.org/cpython/rev/2bc784057226 > changeset: 69858:2bc784057226 > parent: 69856:b06ad8458b32 > parent: 69857:1a56775c6e54 > user: Raymond Hettinger <pyt...@rcn.com> > date: Thu May 05 11:38:06 2011 -0700 > summary: > Avoid codec spelling issues by just using the utf-8 default. > > files: > Lib/random.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > diff --git a/Lib/random.py b/Lib/random.py > --- a/Lib/random.py > +++ b/Lib/random.py > @@ -114,7 +114,7 @@ > if version == 2: > if isinstance(a, (str, bytes, bytearray)): > if isinstance(a, str): > - a = a.encode("utf-8") > + a = a.encode()
Isn't explicit better than implicit? By reading the new code it is not obvious that any thought was given to the choice of a codec, while stating "utf-8" explicitly hints that a decision was made. (also, I don't understand the spelling issue: "utf-8" just works) Regards Antoine. _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
