On 5/26/2011 10:34 AM, Ronald Oussoren wrote: > > On 26 May, 2011, at 16:10, Eric Smith wrote: >> >> >>> and make silent the Clang Static Analyzer :-) >> >> I care less about that than maintainability and future-proofing. > > Have to looked at the patch? The patch and resulting code look sane to me, > and if anything at most of the updated segments look cleaner after the patch.
I have looked at it. I think the code was better before the patch. If I were looking at this, I'd have to wonder why the pointer was incremented everywhere else, but not here. This is especially true when the changed code isn't particularly near the end of the function. _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
