Hi,
with the new Unicode API, there are many checks like:
+ if (PyUnicode_READY(*filename))
+ goto handle_error;
Every time I read it, I get it wrong:
"If filename is ready, then fail"
then I have to remember that the function returns either 0 or -1.
I'd prefer it was written :
if (PyUnicode_READY(*filename) < 0)
because "< 0" clearly indicates an error condition.
That's how all calls to PyType_Ready are written, for example.
Am I the only one to be distracted by this idiom?
--
Amaury Forgeot d'Arc
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
