On 12/15/2011 5:31 AM, Vinay Sajip wrote:
In response to http://bugs.python.org/issue13516 I'm thinking of implementing
some changes in the rotating file handlers, as outlined here:

http://plumberjack.blogspot.com/2011/12/improved-flexibility-for-log-file.html

The changes (including tests) are almost ready to check in, but I thought I'd
give any one here who's interested a chance to comment, in case they can spot
any shortcomings of the approach I suggest.

It appears you are adding two methods to do the same thing. One is to subclass and override one or two functions. The other is to define one or two custom functions and attach as attributes. Both seem equally easy. (Actually, subclassing takes one line less.) Are both really needed?

--
Terry Jan Reedy

_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Reply via email to