On Mon, 2 Jan 2012 14:44:49 +1000
Nick Coghlan <[email protected]> wrote:
>
> He keeps leaving them out, I occasionally tell him they should always
> be included (most recently this came up when we gave conflicting
> advice to a patch contributor).
Oh, by the way, this is also why I avoid arguing too much about style
in code reviews. There are two bad things which can happen:
- your advice conflicts with advice given by another reviewer (perhaps
on another issue)
- the contributor feels drowned under tiresome requests for style
fixes ("please indent continuation lines this way")
Both are potentially demotivating. A contributor can have his/her own
style if it doesn't adversely affect code quality.
Regards
Antoine.
_______________________________________________
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
