On Wed, Apr 18, 2012 at 11:31 PM, brian.curtin
<python-check...@python.org> wrote:
> - if (name == NULL)
> + if (name == NULL) {
> + Py_INCREF(Py_None);
> name = Py_None;
> + }
A slightly more traditional way to write that would be:
name = Py_None;
Py_INCREF(name);
> - if (path == NULL)
> + if (path == NULL) {
> + Py_INCREF(Py_None);
> path = Py_None;
> + }
Ditto.
>
> Py_INCREF(msg);
> - PyTuple_SetItem(args, 0, msg);
> + PyTuple_SetItem(args, 0, NULL);//msg);
However, *this* looks a lot more suspicious... accidental commit of
debugging code?
(if not for spotting this last problem, I wouldn't have even mentioned
the first two)
Cheers,
Nick.
--
Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
