2012/7/21 Antoine Pitrou <solip...@pitrou.net>: > Kristján Valur Jónsson <krist...@ccpgames.com> wrote: >> >> The code will raise ValueError when int(1) is passed in, but the >> unittests expect a TypeError. > > Well, if test_hashlib passes, surely your analysis is wrong, no?
In the normal case, yes: >>> import hashlib >>> hashlib.new(1) TypeError: name must be a string But if the _hashlib extension module is not available, the python version is used and ValueError is raised: >>> import sys >>> sys.modules['_hashlib'] = None >>> import hashlib >>> hashlib.new(1) ValueError: unsupported hash type 1 -- Amaury Forgeot d'Arc _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
