On 07/22/2012 06:10 PM, Andrew Svetlov wrote: > Georg, sorry, I've committed it before you answered.
After you wrote that you'd wait three days... anyway, I can't find the commit in the repository, so that's fine. > If you want, I will revert it back. > But, please, describe me why those scripts are to late for 3.3? > I strongly checked correctness of both activation script for fish and > csh/tsch shells. > Works fine. "Works fine" is not good enough. There are hundreds of potential patches on the tracker implementing new features of which the same could be said. > It's not *new feature*, it is just extending support to csh and fish shells. That is a new feature in my view. If it was an important feature, someone would have thought of it while features were allowed. > Virtualenv (base for venv) already contains this activation scripts. > I just converted those files to venv with replacing virtualenv > specific environment variables to schema supported by venv. > I see nothing bad for adding to venv support for fish and csh as well > as already supported bash/zsh > > Say again, I triple checked correctness of added scripts. With > defining VIRTUAL_ENV_DISABLE_PROMPT as well as without it. > My addition is safe, trivial, correct and it is not new feature — just > fixing of missing support for widely used shells. > > Anyway. > You are Release Manager — the main person for 3.3 release. > If you feel what my changes is potentially dangerous and should be > removed from 3.3 — I'll do it. > But, please, do benevolent. The point of feature freeze is that there are no new features. Where can I draw the line, when everybody argues like that and I agree? Georg _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
