Am 11.01.2013 07:09, schrieb Nick Coghlan: > On Fri, Jan 11, 2013 at 2:57 PM, <solip...@pitrou.net> wrote: >> results for aef7db0d3893 on branch "default" >> -------------------------------------------- >> >> test_dbm leaked [2, 0, 0] references, sum=2 >> test_dbm leaked [2, 2, 1] memory blocks, sum=5 > > Hmm, I'm starting to wonder if there's something to this one - it > seems to be popping up a bit lately. > >> test_xml_etree_c leaked [56, 56, 56] references, sum=168 >> test_xml_etree_c leaked [36, 38, 38] memory blocks, sum=112 > > I'm gonna take a wild guess and suggest there may be a problem with > the recent pickling fix in the C extension :)
It has more issues. Coverity has sent me some complains, see attachment.
--- Begin Message ---Hi, Please find the latest report on new defect(s) introduced to Python found with Coverity SCAN Defect(s) Reported-by: Coverity Scan ** CID 967027: Dereference null return value (NULL_RETURNS) /Modules/_elementtree.c: 966 http://scan5.coverity.com:8080//sourcebrowser.htm?projectId=10226#mergedDefectId=967027 ** CID 967026: Dereference after null check (FORWARD_NULL) /Modules/_elementtree.c: 841 http://scan5.coverity.com:8080//sourcebrowser.htm?projectId=10226#mergedDefectId=967026 ________________________________________________________________________ CID 967027: Dereference null return value (NULL_RETURNS) /Modules/_elementtree.c: 963 ( returned_null) 960 961 /* More instance dict members than we know to handle? */ 962 tag = attrib = text = tail = children = NULL; >>> Function "PyTuple_New(Py_ssize_t)" returns null (checked 169 out of 190 >>> times). 963 args = PyTuple_New(0); 964 error = ! PyArg_ParseTupleAndKeywords(args, state, "|$OOOOO", kwlist, &tag, 965 &attrib, &text, &tail, &children); 966 Py_DECREF(args); 967 if (error) /Modules/_elementtree.c: 963 ( var_assigned) 960 961 /* More instance dict members than we know to handle? */ 962 tag = attrib = text = tail = children = NULL; >>> Assigning: "args" = null return value from "PyTuple_New(Py_ssize_t)". 963 args = PyTuple_New(0); 964 error = ! PyArg_ParseTupleAndKeywords(args, state, "|$OOOOO", kwlist, &tag, 965 &attrib, &text, &tail, &children); 966 Py_DECREF(args); 967 if (error) /Modules/_elementtree.c: 966 ( dereference) 963 args = PyTuple_New(0); 964 error = ! PyArg_ParseTupleAndKeywords(args, state, "|$OOOOO", kwlist, &tag, 965 &attrib, &text, &tail, &children); >>> CID 967027: Dereference null return value (NULL_RETURNS) >>> Dereferencing a null pointer "args". 966 Py_DECREF(args); 967 if (error) 968 return NULL; 969 else 970 return element_setstate_from_attributes(self, tag, attrib, text, ________________________________________________________________________ CID 967026: Dereference after null check (FORWARD_NULL) /Modules/_elementtree.c: 837 ( var_compare_op) 834 PyObject *instancedict = NULL, *children; 835 836 /* Build a list of children. */ >>> Comparing "self->extra" to null implies that "self->extra" might be null. 837 children = PyList_New(self->extra ? self->extra->length : 0); 838 if (!children) 839 return NULL; 840 for (i = 0; i < PyList_GET_SIZE(children); i++) { 841 PyObject *child = self->extra->children[i]; /Modules/_elementtree.c: 841 ( var_deref_op) 838 if (!children) 839 return NULL; 840 for (i = 0; i < PyList_GET_SIZE(children); i++) { >>> CID 967026: Dereference after null check (FORWARD_NULL) >>> Dereferencing null pointer "self->extra". 841 PyObject *child = self->extra->children[i]; 842 Py_INCREF(child); 843 PyList_SET_ITEM(children, i, child); 844 } 845 ________________________________________________________________________ To view the defects in Coverity Scan visit, http://scan5.coverity.com:8080 If you don't have a username, you can request one by emailing: scan-ad...@coverity.com To unsubscribe from the email notification for new defects, http://scan.coverity.com/email_unsubscribe.html If you are project owner, you can subscribe your team member by accessing http://scan.coverity.com/email_subscription.html
--- End Message ---
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
