On 3 Aug 2013 12:45, "Terry Reedy" <tjre...@udel.edu> wrote: > > > > On 8/2/2013 10:26 PM, Nick Coghlan wrote: >> >> >> On 3 Aug 2013 11:07, "Terry Reedy" <tjre...@udel.edu >> <mailto:tjre...@udel.edu>> wrote: >> > >> > On 8/2/2013 6:19 AM, nick.coghlan wrote: >> > >> >> +The Python standard library is conservative and requires limiting >> >> +lines to 79 characters (and docstrings/comments to 72). >> > >> > >> > If you (and Guido) mean that as a hard limit, then patchcheck should >> check line lengths as well as trailing whitespace. >> >> That raises issues when modifying existing non-compliant files, because >> it removes the human judgement on whether a non-compliance is worth >> fixing or not. > > > I meant tools/scripts/patchcheck.py, not the pre-commit hook. The check would inform (especially for old files) or remind (for new files) so that judgment could be applied.
Ah, right. Yeah, that may be reasonable. A warning option on reindent.py may be a place to start if someone wanted to implement it. Whether or not patchcheck used that option would likely depend on the initial results of running it manually :) Cheers, Nick. > > _______________________________________________ > Python-checkins mailing list > python-check...@python.org > http://mail.python.org/mailman/listinfo/python-checkins
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
