On 8 Nov 2013 09:45, "Victor Stinner" <victor.stin...@gmail.com> wrote: > > Hi, > > [PyRun_InteractiveOneObject()] > > 2013/11/8 Nick Coghlan <ncogh...@gmail.com>: > > New C APIs should either be documented or have an underscore prefix. > > I created the issue #19518 to add documentation (but also to add even > more functions :-)). > > > Also, if they're part of the stable ABI, they need a version guard. > > As most PyRun_xxx() functions, the function is declared in a "#ifndef > Py_LIMITED_API" block. It means that it is not part of the stable ABI, > is that correct?
Yeah, that's fine - I'm just replying on my phone at the moment, so checking the broader file context is a pain :) Cheers, Nick. > > > Wishlist item: an automated ABI checker that can diff the exported symbols > > against a reference list (Could ctypes or cffi be used for that?) > > Yeah, it would be nice to have a tool to list changes on the stable ABI :-) > > * * * > > For a previous issue, I also added various other functions like > PyParser_ASTFromStringObject() or PyParser_ASTFromFileObject(). As > PyRun_InteractiveOneObject(), they are declared in a "#ifndef > Py_LIMITED_API" block in pythonrun.h. These new functions are not > documented, because PyParser_AST*() functions are not documented. > > http://bugs.python.org/issue11619 > http://hg.python.org/cpython/rev/df2fdd42b375 > > The patch parser_unicode.patch was attached to the issue during 2 > years. First I didn't want to commit it becaues it added too many new > functions. But I pushed by change because some Windows users like > using the full Unicode range in the name of their scripts and modules! > > If it's not too late, I would appreciate a review of the stable ABI of > this changeset. > > Victor > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: https://mail.python.org/mailman/options/python-dev/ncoghlan%40gmail.com
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com