On Sat Feb 21 2015 at 4:23:16 PM Ben Hoyt <benh...@gmail.com> wrote: > When merging some changes while working on scandir, I noticed a minor > issue with this commit: > > https://hg.python.org/cpython/rev/4f6f4aa0d80f > > The definition of "struct win32_stat" has been moved to fileutils.h and > renamed to "struct _Py_stat_struct", which is fine -- however, the old > "struct win32_stat" definition is still present (but unused) in > posixmodule.c. > > So I think the old "struct win32_stat { ... }" definition can simply be > removed from posixmodule.c now. >
I don't think win32_stat is part of the stable ABI so as long as everything keeps working then I don't see why it needs to stick around. > > Also, unrelated to this commit, I notice the _Py_attribute_data_to_stat > function (was attribute_data_to_stat) can't fail and always returns 0, and > all callers ignore its return value anyway. Can it be changed to return > void? > Don't see why not since it's a private API.
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
