Hi all, Based on the feedback I received, I updated the patch to introduce django_v3 benchmark, which uses django 1.8. Also, django_v2 was deprecated for Python 3.6 and above. In order for django_v3 to work, the latest django release must be present in lib/Django-1.8. Django-1.8 is attached as a zip file because the patch would be too large if it included all these files. In order for the modifications to work, extract the archive to lib/Django-1.8 .
Please see the issue here: http://bugs.python.org/issue24934 Thank you, Florin Papa On Tue, 25 Aug 2015 at 08:31 R. David Murray <rdmur...@bitdance.com> wrote: On Tue, 25 Aug 2015 11:18:54 -0400, Terry Reedy <tjre...@udel.edu> wrote: > On 8/25/2015 10:51 AM, R. David Murray wrote: > > On Tue, 25 Aug 2015 13:11:37 -0000, "Papa, Florin" <florin.p...@intel.com> > > wrote: > >> My name is Florin Papa and I work in the Server Languages Optimizations > >> Team at Intel Corporation. > >> > >> I would like to submit a patch that solves compatibility issues of the > >> django_v2 benchmark in the Grand Unified Python Benchmark. The django_v2 > >> benchmark uses inspect.getargspec(), which is deprecated and was removed > >> in Python 3.6. Therefore, it crashes with the message "ImportError: cannot > >> import name 'getargspec'" when using the latest version of Python on the > >> default branch. > >> > >> The patch modifies the benchmark to use inspect.signature() when Python > >> version is 3.6 or above and keep using inspect.getargspec() otherwise. > > > > Note that Papa has submitted the patch to the tracker: > > > > http://bugs.python.org/issue24934 > > > > I'm not myself sure how we are maintaining that repo > > (https://hg.python.org/benchmarks), but it does seem like the bug > > tracker is the right place for such a patch. > > Is the django_v2 benchmark original to benchmarks, or a copy from django? Yeah, that's one question that was in my mind when I said I don't know how we maintain that repo. I'm pretty sure it was originally a copy of the django project, but how do we maintain it? It's maintained by primarily Antoine and me occasionally doing stuff to it. =) Traditionally bugs have been reported to bugs.python.org. As for the django_v2 benchmark, it was created by Unladen Swallow (it's v2 because it was updated to work with Django 1.5 so as to get Python 3 support for the benchmark). IOW it's out own benchmark and we can do whatever we want with it. _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
