On 02/12/2016 10:45 AM, Serhiy Storchaka wrote: > Sorry to bringing this up again. I was hoping we were done with that. > > When discussing the name of the Py_SETREF macro I was supposed to add a > pair of macros: for Py_DECREF and Py_XDECREF. But I got a lot of > opinions to be limited to only one macro. > > There was no (besides my) clearly expressed vote for two macros.
I would have voted in favor. Spelling the SETREF out, as Nick proposes, kind of defies the purpose of the macro: it's not strictly a convenience macro, it helps prevent refcounting bugs. > As a result I have replaced both Py_DECREF and Py_XDECREF with the macro > that always uses Py_XDECREF. Can you roughly say which fraction of replacements changed DECREF to an implicit XDECREF? Georg _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
