On Wed, Jan 18, 2017 at 8:48 AM, Larry Hastings <la...@hastings.org> wrote: > > On 01/17/2017 12:02 PM, Steve Dower wrote: > > Avoiding header files would be my only request. As Brett says, the C99 > requirement should not be enforced on all embedders or extenders, so we > should try and keep the headers they'll use as compatible as possible. > >
C99 style comment is used in header file already. see http://bugs.python.org/issue29215 > > While that's a reasonable policy, unless we have a way to automatically > detect that I suspect C99 stuff will creep into the header files and break > the non-C99 customers. Maybe we could get some sort of buildbot that > exercises this scenario? > How about `gcc -ansi` ? $ cat head.c #include <Python.h> $ gcc `python-config --cflags` -ansi -c head.c In file included from /home/inada-n/pyenv/versions/3.6.0/include/python3.6m/Python.h:50:0, from head.c:1: /home/inada-n/pyenv/versions/3.6.0/include/python3.6m/pyport.h:40:1: error: C++ style comments are not allowed in ISO C90 // long long is required. Ensure HAVE_LONG_LONG is defined for compatibility. ^ /home/inada-n/pyenv/versions/3.6.0/include/python3.6m/pyport.h:40:1: error: (this will be reported only once per input file) ~ > > /arry > > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > https://mail.python.org/mailman/options/python-dev/songofacandy%40gmail.com > _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com