On 30 August 2017 at 10:48, Nick Coghlan <ncogh...@gmail.com> wrote: > On 30 August 2017 at 19:39, Antoine Pitrou <solip...@pitrou.net> wrote: >> On Wed, 30 Aug 2017 08:48:56 +0300 >> Serhiy Storchaka <storch...@gmail.com> wrote: >>> Please, please don't forget to edit commit messages before merging. An >>> excessively verbose commit message will be kept in the repository >>> forever and will harm future developers that read a history. >> >> Sorry, I routinely forget about it. Can we have an automated check for >> this? > > Not while we're pushing the "squash & merge" button directly, as > there's no opportunity for any automated hooks to run at that point :( > > More options open up if the actual commit is being handled by a bot, > but even that would still depend on us providing an updated commit > message via some mechanism.
We could have a check for PRs that contain multiple commits. The check would flag that the commit message needs manual editing before merging, and would act as a prompt for submitters who are willing to do so to squash their PRs themselves. Personally, I'd prefer that as, apart from admin activities like making sure the PR and issue number references are present and correct, I think the original submitter has a better chance of properly summarising the PR in the merged commit message anyway. Paul _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
