On Tue, Jan 16, 2018 at 5:33 PM, Yury Selivanov <yselivanov...@gmail.com> wrote:
> On Tue, Jan 16, 2018 at 8:27 PM, Nathaniel Smith <n...@pobox.com> wrote: > [..] > > token = cvar.set(...) > > token.reset() > > I see the point, but I think that having the 'reset' method defined on > the ContextVar class is easier to grasp. It also feels natural that a > pair of set/reset methods is defined on the same class. This is > highly subjective though, so let's see which option Guido likes more. > I think this came up in one of the previous reviews of the PEP. I like Yury's (redundant) version -- it makes it clear to the human reader of the code which variable is being reset. And it's not like it's going to be used that much -- it'll be likely hidden inside a context manager. -- --Guido van Rossum (python.org/~guido)
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
