It has to be manually edited right before you commit/merge on GitHub. I don't think it can be automatically changed? Unless we have some kind of post commit hook to amend the commit message.
I've been changing it to GH- , so does miss-islington when she backports. If you see the mixed GH- and # in the backports PR, it's because miss-islington converted the first one. On Jan 25, 2018 4:21 AM, "Berker Peksağ" <berker.pek...@gmail.com> wrote: > On Thu, Jan 25, 2018 at 1:42 PM, INADA Naoki <songofaca...@gmail.com> > wrote: > > Hi. > > > > Devguide says: > > > > """ > > Replace the reference to GitHub pull request #NNNN with GH-NNNN. If > > the title is too long, the pull request number can be added to the > > message body. > > """ > > > > https://devguide.python.org/gitbootcamp/#accepting-and- > merging-a-pull-request > > > > But there are more #NNNN than GH-NNNN in commit log. > > https://github.com/python/cpython/commits/master > > > > Where should we go? > > Encourage GH-NNNN? or abandon it and use default #NNNN? > > I'd personally drop both GH-NNNN and #NNNN markers. The number of the > PR is already linked to the commit on GitHub: > https://www.dropbox.com/s/zzm9f56485pbl1v/Screenshot% > 20from%202018-01-25%2015%3A14%3A28.png?dl=0 > > You can even see both styles in the same commit (especially in backport > PRs) > > bpo-42: Fix spam eggs (GH-2341) (#2211) > > --Berker > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: https://mail.python.org/mailman/options/python-dev/ > mariatta.wijaya%40gmail.com >
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
