Hello,

tox was updated in Feodra 33+ to 3.19.

I've managed to get a backwards incompatible change of behavior into that release. Previously, when there was no tox.ini, but there was setup.cfg, tox proceeded without checking the content of setup.cfg.

This lead to a dangerous behvior: `tox` (and `%tox`) would exit with 0 if there were no tox-configured tests. This is now changed: If setup.cfg is present, but contains no tox-related configuration, tox will fail:

    ERROR: tox config file (either pyproject.toml, tox.ini, setup.cfg) not found

This manifests like this with `%pyproject_buildrequires -t`:
    ...
    Handling tox-current-env >= 0.0.2 from tox itself
    Requirement satisfied: tox-current-env >= 0.0.2
       (installed: tox-current-env 0.0.2)
    ERROR: tox config file (either pyproject.toml, tox.ini, setup.cfg) not found
    Traceback (most recent call last):
      File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 322, in main
        generate_requires(
File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 269, in generate_requires
        generate_tox_requirements(toxenv, requirements)
File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 231, in generate_tox_requirements
        r.check_returncode()
      File "/usr/lib64/python3.9/subprocess.py", line 456, in check_returncode
        raise CalledProcessError(self.returncode, self.args, self.stdout,
subprocess.CalledProcessError: Command '['/usr/bin/python3', '-m', 'tox', '--print-deps-to-file', '/tmp/tmpgvu_6190', '-qre', 'py39']' returned non-zero exit status 1.
    error: Bad exit status from /var/tmp/rpm-tmp.n92yaC 
(%generate_buildrequires)


The mitigation is to not use tox if upstream doesn't have tox configuration.

This change broke python-latexcodec and python-pybtex-docutils:

https://koschei.fedoraproject.org/build/8698931
https://koschei.fedoraproject.org/build/8698932

I'll fix them.

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
python-devel mailing list -- python-devel@lists.fedoraproject.org
To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org

Reply via email to