On 30. 10. 21 21:42, Gordon Messmer wrote:
On 10/29/21 05:49, Miro Hrončok wrote:
For some of them (e.g. mako), this seems to be a mistake even.
There are a lot of "dev0" versions in that set, so I took a look for the
cause. It looks like all of the "dev0" packages use github source rather than
PyPI sources, which means that none of the release process defined in
setup.py/cfg is being used for those packages; they're just tarballs of the git
repo.
https://src.fedoraproject.org/rpms/python-mako/blob/rawhide/f/python-mako.spec#_11
"dev0" doesn't appear to be a bug in the scripts. Builds from github are
intentionally marked dev releases:
https://github.com/sqlalchemy/mako/blob/main/setup.cfg#L72
That pattern also appears in the updated policy document:
https://fedoraproject.org/wiki/Changes/PythonPackagingGuidelines202x
I'd suggest that we should instead strongly encourage the use of PyPI URLs.
That is however not always possible, see
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi
I think we need to enhance that section with tips for when using a git tarball
wrt setuptools_scm and tag_build = dev
See for example https://src.fedoraproject.org/rpms/python-mako/pull-request/13
(it doesn't even use git snapshot, but upstream release tarball).
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
python-devel mailing list -- python-devel@lists.fedoraproject.org
To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
