On 19/02/2019 16:26, Anders Hovmöller wrote:

If it were me, I'd probably write (or would have re-written when I added
the type hints) that as follows:

    def resolve_annotations(
            *,
            raw_annotations: Dict[str, Type[Any]],
            module_name: Optional[str]
        ) -> Dict[str, Type[Any]]:

I would like to point out here that breaking up a line breaks grepping quite 
badly. I've had to write AST-based searches to find simple usages of arguments 
in the code base at work precisely because of code that is split on likes like 
this. (This tool is available here: https://github.com/boxed/parso_utils)

How odd. I always break up long lines like this, and I've never once had an issue grepping.

--
Rhodri James *-* Kynesim Ltd
_______________________________________________
Python-ideas mailing list
Python-ideas@python.org
https://mail.python.org/mailman/listinfo/python-ideas
Code of Conduct: http://python.org/psf/codeofconduct/

Reply via email to