On Tue, May 4, 2021 at 5:16 AM Caleb Donovick <donov...@cs.stanford.edu> wrote: > > For the record I am definitely a -1 on this. The arguments against are > overwhelming and the arguments for are pretty weak. However I felt the need > to rebut: > > > Tests don't really count, so there's a small handful here. > > Tests 100% count as real use cases. If this is a pattern that would be > useful in test case generation then we should be discussing that. I have > worked on plenty of projects which were almost exclusively documented through > tests. Being able to read and write tests fluently is as important as any > other piece of code. >
That's true, but in many cases, tests are there to test specific functionality. Since no functionality is being removed, anything that's testing str.join() will need to continue testing str.join(). I didn't dig into the specific examples to see which ones were testing str.join and which ones happened to be using str.join to test something else. ChrisA _______________________________________________ Python-ideas mailing list -- python-ideas@python.org To unsubscribe send an email to python-ideas-le...@python.org https://mail.python.org/mailman3/lists/python-ideas.python.org/ Message archived at https://mail.python.org/archives/list/python-ideas@python.org/message/UKM2AR4WTXG4PJ3Y3YUCESB4THEKU47K/ Code of Conduct: http://python.org/psf/codeofconduct/