> Why not use just to_bool(getenv(key))?

We did use distutils.util.strtobool(os.getenv(key, default)) for a while,
eventually we just built a helper that did the same because it's easier /
more comfortable.

> No. There would be hundreds different trivial implementations.

Can you elaborate? Here's more or less what I had in mind (using the
os.getenv source code as template):

from distutils.util import strtobool

def getenv(key, default=None, to_bool=False):
     """Get an environment variable, return None if it doesn't exist.
     The optional second argument can specify an alternate default.
     key, default and the result are str."""
     val = environ.get(key, default)
     return val if not to_bool else strtobool(val)

Sure, there are other ways to implement that are probably equally trivial,
but why does that matter?

On Wed, Mar 30, 2022 at 3:50 PM Serhiy Storchaka <storch...@gmail.com>
wrote:

> 30.03.22 14:05, Adrian Torres Justo пише:
> > We've used a lot of boolean environment variables in a recent project
> > I've been working on, this led us to create a wrapper to os.getenv that
> > essentially converts the result to a boolean using
> > distutils.util.strtobool if an optional kwarg to our wrapper is set to
> True.
> >
> > Would it be far-fetched to have os.getenv incorporate this
> > functionality? We already have the building blocks (strtobool and
> > getenv), and the signature change would be minimal and
> backwards-compatible:
> >
> > def getenv(key, default=None, to_bool=False):
> >      ...
>
> Why not use just to_bool(getenv(key))?
>
> > The implementation would be trivial too.
>
> No. There would be hundreds different trivial implementations.
>
> _______________________________________________
> Python-ideas mailing list -- python-ideas@python.org
> To unsubscribe send an email to python-ideas-le...@python.org
> https://mail.python.org/mailman3/lists/python-ideas.python.org/
> Message archived at
> https://mail.python.org/archives/list/python-ideas@python.org/message/HHK3BTZTWNG7U4KCUVYTMXF3IIH4UMIP/
> Code of Conduct: http://python.org/psf/codeofconduct/
>
_______________________________________________
Python-ideas mailing list -- python-ideas@python.org
To unsubscribe send an email to python-ideas-le...@python.org
https://mail.python.org/mailman3/lists/python-ideas.python.org/
Message archived at 
https://mail.python.org/archives/list/python-ideas@python.org/message/X57VKNSN3ZVKBY3M7SCR5P5Z2DCJC4SP/
Code of Conduct: http://python.org/psf/codeofconduct/

Reply via email to