Reviewed: https://review.opendev.org/700196
Committed:
https://git.openstack.org/cgit/jjb/python-jenkins/commit/?id=19e7f7395aaa0d876a39baf82a80b775d17ff2b3
Submitter: Zuul
Branch: master
commit 19e7f7395aaa0d876a39baf82a80b775d17ff2b3
Author: Pascal Hofmann <m...@pascalhofmann.de>
Date: Fri Dec 20 17:08:26 2019 +0100
Include placeholder tasks in get_running_builds
Pipeline jobs in in Jenkins 2.x appear as placeholder tasks for their
entire lifetime when queried via the API. The fix for #1659787
introduced completly ignoring placeholder tasks. Thus pipeline jobs are
never included in the list returned by get_running_builds.
This commit will change the behaviour of get_running_builds as follows:
- Placeholder tasks will be included: So running pipeline jobs
will be included.
- Builds which do not have a build number yet will be ignored:
This prevents the exception described in #1659787.
Change-Id: I30351ec78d6186b0674e3c08be00076b0ce2333e
Closes-Bug: #1750372
Related-Bug: #1659787
--
You received this bug notification because you are a member of Python
Jenkins Developers, which is subscribed to Python Jenkins.
https://bugs.launchpad.net/bugs/1659787
Title:
`get_running_builds` raises an error when there are placeholder tasks
Status in Python Jenkins:
Fix Released
Bug description:
The `get_running_builds` method on the `Jenkins` class will raise an
exception when it tries to return a list of running builds which
contains placeholder tasks.
This line tries to access a build number, which isn't yet available:
https://github.com/openstack/python-jenkins/blob/0f6739103b8b02e3c55ad8d8f4bbb5265273d669/jenkins/__init__.py#L1151
```
>>> j = Jenkins('https://jenkins.example.com', username='jenkins_user',
password='password1')
>>> j.get_running_builds()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.6/site-packages/jenkins/__init__.py", line
1151, in get_running_builds
build_number = executable['number']
KeyError: 'number'
```
To manage notifications about this bug go to:
https://bugs.launchpad.net/python-jenkins/+bug/1659787/+subscriptions
--
Mailing list: https://launchpad.net/~python-jenkins-developers
Post to : python-jenkins-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~python-jenkins-developers
More help : https://help.launchpad.net/ListHelp
