-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi Georg,
On Jan 05, 2011, at 09:58 PM, Georg Brandl wrote: >I have some more changes that I'd like to discuss before committing. (These >are features in my patched version at bitbucket.org/birkenfeld/dotemacs). > >Basically: > >* a separate face for class names: font-lock-type-face is meant for types in > type declarations and therefore usually not a very noticeable face. For > example I like to have class names underlined, but having > font-lock-type-face underlined looks very odd in c-mode. > >* a separate face for exception classes: somewhat redundant, but looks nice. > Both for builtin exceptions and any name after a raise or except. Both of these sound good to me. I checked out and tested your branch, and reviewed it. I think there are only two minor issues that need fixing, but it otherwise looks good. >* special locking for escape sequences and %-formatting codes in strings, like > the equivalent feature in elisp-mode. > > (The code seems to have some issues with font-locking buffers, so I'd be > glad for suggestions how to fix it.) I'm not sure I understand what the issues are. I tested it with a few Mailman files and it looked okay, though the extra bolding was a little off-putting (yeah, I'll be customizing those faces as soon as your changes land :). What are the problems? Not that I'm an expert on all the insane font-lock possibilities. >* no filling in code (that one is pretty simple, just remove the "fill- > paragraph" in the last condition of py-fill-paragraph). +1! If that's the bug I think it is, it's been annoying me for about a bazillion years. E.g. I want to be able to fill comments for sure, maybe strings, but never code. >BTW, while looking at this, something is still not quite right with the >parsing of triple-quoted string literals... as can be witnessed when filling >a TQS with embedded SQS... Can you provide an example? >If I can figure out how to do it, I'll commit these changes separately to a >private branch on launchpad, so that they can be reviewed. Two additional things would be nice if anyone's so inclined. * Adding a NEWS file; I don't care how far back into history it goes. * Maybe some nice screen grabs of face examples so folks have a visual way of seeing what their font-lock options are. - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBCAAGBQJNJPydAAoJEBJutWOnSwa/eLMP/AmfQCJEpEHLRuKr2lyoTeFL rlZFwF8k1ypn3J0UASqlt5xMgUJGwZLZklyedoRtzFe5Q7ubqWn7rFlTITEcP9UP PmJhIZOhpt5TtwRC+wCKaKOFx2YtycbPn5rL0CRW0AZh5rsZTqFa35Gzl08Iqzuo 7qNoTDqt6hNaN8AdNS1XxGvGv4ydHjX21JM2lFAGYhuBcUpSXdZ4D19nNh/X460Y IIdiQQRWgcmiqwefiQQcTxDndYQadAVvhSDwOrukdcSnfOxp6nKTXS5SWp55BbUo Gzzx38C9emnESMKjChvfkSlTkjw58SUEwuBdRKCdX0oluGUf13xGaVaFmQRx0Fu3 +oqCMa0tXx0b29E2HzP00V7TcCQeWCCwqW03qN10xBWIxdfYFlVIpA4zh+MG5nUe h+8AVzGO9MTCImsIC6UQLSi318oq0dOGp0Mr05Y0HYv4v6sv+TUhWZIqMVZvsqLJ D5ob0y85bvrLCWva1HI09K7AOWLw1cHIRNZwGRJ++SubrDGdwd3diZYQUcWhGTpP CHLTRM7eSBjCMvASzHMD7upePFI9Hkn5zJTybCLtMsMC8FXpyNJbbmY9Elnx2x98 Z4VPL/dhS/42rXGU7tBfHdCMbtm7RNq2uKK7noKP0SY3UHZ83YFqBUkZiUsHvHdU JnPOgzCQAHqj7CFzwPvy =OKPX -----END PGP SIGNATURE----- _______________________________________________ Python-mode mailing list Python-mode@python.org http://mail.python.org/mailman/listinfo/python-mode
