On Apr 14, 2011, at 11:18 PM, Andreas Röhler wrote: >think we have discussed that with bug #748198: > >col 8 will be reached _after_ the closing paren, not before. > >When inside a dict, its pairs get piled up. > >Unless you want to have that otherwise....
Hi Andreas, yes this is slightly different. Let's look at two examples.
-----snip snip-----
def foo():
x = dict(a=1,
-----snip snip-----
When point is after the comma and you hit return, the next line should line up
under the 'a'. Which it does, so there's no problem here.
-----snip snip-----
def foo():
x = dict(
-----snip snip-----
Here, the open paren is the last thing on the line. When point is after the
open paren and you hit return, you should land 4 spaces indented from under
the 'x', not (as is currently the case) to the space right of the open paren.
This is because you'll end up writing this:
-----snip snip-----
def foo():
x = dict(
a=1,
b=2,
c=3,
)
-----snip snip-----
>> I think once you've fixed this, myrkwid will be ready to merge into the
>> trunk. Everything else so far is looking really good.
>>
>> Once myrkwid is merged, I would like to do a branch format update. This will
>> mean any other branches people have will also have to be updated (or for the
>> trunk, you can just re-branch it).
>>
>> Also, I think your changes are significant enough to merit a minor version
>> bump, so I propose we bump it to 5.3.0.
>
>Really feeling honoured, thanks :)
Hey, you've done a lot of great work, which we all appreciate!
>Then if it looks good for a while and
>> you have no other changes you want to get in, we should do a release.
>
>Further fixes still ahead will take a little bit longer probably. Maybe we
>should keep the trunk for some days before a release, to get some more
>testers.
Yes, definitely. So, can you fix the above bug? Then we'll merge myrkwid
into trunk and let folks test that for a little while. There's no rush on the
new release, but I do want to update the branch format as soon as possible.
-Barry
signature.asc
Description: PGP signature
_______________________________________________ Python-mode mailing list Python-mode@python.org http://mail.python.org/mailman/listinfo/python-mode
