Your message dated Sat, 29 Feb 2020 16:19:53 +0000
with message-id <[email protected]>
and subject line Bug#950138: fixed in pikepdf 1.10.2+dfsg-1
has caused the Debian Bug report #950138,
regarding pikepdf: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
950138: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=950138
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: pikepdf
Version: 1.10.0+dfsg-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: randomness filesystem
X-Debbugs-Cc: [email protected]

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
pikepdf could not be built reproducibly.

This was due to two reasons:

a) The documentation included tutorial/walthrough like output like so:

   <PIL.JpegImagePlugin.JpegImageFile image mode=RGB size=1000x1520 at 
0x7F04BAC72B90>

   … where the 0x7F04BAC72B90 part is non-determinstic and thus varies
   between builds.


b) The .cpp input files were compiled/linked in an order that was
   determined by their layout on the filesystem which is, at least in
   UNIX systems, non-deterministic.

Patch attached that addresses both these issues.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
--- a/debian/patches/reproducible-build.patch   1970-01-01 01:00:00.000000000 
+0100
--- b/debian/patches/reproducible-build.patch   2020-01-29 11:33:20.626556034 
+0100
@@ -0,0 +1,37 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2020-01-29
+
+--- pikepdf-1.10.0+dfsg.orig/docs/topics/images.rst
++++ pikepdf-1.10.0+dfsg/docs/topics/images.rst
+@@ -36,7 +36,7 @@ dictionaries.
+ 
+     In [1]: pdfimage = PdfImage(rawimage)
+ 
+-    In [1]: pdfimage
++    In [1]: type(pdfimage)
+ 
+ In Jupyter (or IPython with a suitable backend) the image will be
+ displayed.
+@@ -84,7 +84,7 @@ You can also retrieve the image as a Pil
+ 
+ .. ipython::
+ 
+-    In [1]: pdfimage.as_pil_image()
++    In [1]: type(pdfimage.as_pil_image())
+ 
+ Another way to view the image is using Pillow's ``Image.show()`` method.
+ 
+--- pikepdf-1.10.0+dfsg.orig/setup.py
++++ pikepdf-1.10.0+dfsg/setup.py
+@@ -42,8 +42,8 @@ if 'bsd' in sys.platform:
+ ext_modules = [
+     Extension(
+         'pikepdf._qpdf',
+-        glob('src/qpdf/*.cpp'),
+-        depends=glob('src/qpdf/*.h'),
++        sorted(glob('src/qpdf/*.cpp')),
++        depends=sorted(glob('src/qpdf/*.h')),
+         include_dirs=[
+             # Path to pybind11 headers
+             get_pybind_include(),
--- a/debian/patches/series     2020-01-29 11:09:31.619837542 +0100
--- b/debian/patches/series     2020-01-29 11:19:45.147172680 +0100
@@ -3,3 +3,4 @@
 disable-test_docinfo_problems.patch
 drop-pybind11-from-setup.py.patch
 disable-test_icc_extract.patch
+reproducible-build.patch

--- End Message ---
--- Begin Message ---
Source: pikepdf
Source-Version: 1.10.2+dfsg-1
Done: Sean Whitton <[email protected]>

We believe that the bug you reported is fixed in the latest version of
pikepdf, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sean Whitton <[email protected]> (supplier of updated pikepdf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 29 Feb 2020 08:56:25 -0700
Source: pikepdf
Architecture: source
Version: 1.10.2+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Modules Team 
<[email protected]>
Changed-By: Sean Whitton <[email protected]>
Closes: 950138
Changes:
 pikepdf (1.10.2+dfsg-1) unstable; urgency=medium
 .
   * New upstream release (Closes: #950138).
Checksums-Sha1:
 8e4c4b575ff2fee72d5b14d137bd5351e1344bb2 2625 pikepdf_1.10.2+dfsg-1.dsc
 82bfc49f66f2f2ab973417e14561fd87c65ee0c1 1523144 
pikepdf_1.10.2+dfsg.orig.tar.xz
 b202ef7078ecc104f4c6dab277cbe2e011fc3044 1922920 
pikepdf_1.10.2+dfsg-1.debian.tar.xz
Checksums-Sha256:
 a74ace49a9d691812cdfe10c0f2a1a9c27b2ce669e47621899b989c7d4e57ab5 2625 
pikepdf_1.10.2+dfsg-1.dsc
 17111e159e70f0302ad234ccba93babfe4ac73c0aed22acd2d6415775293976c 1523144 
pikepdf_1.10.2+dfsg.orig.tar.xz
 3d16f768a1ed45026fa8c6692ebb0c232f0908b505441732d080063ae373c519 1922920 
pikepdf_1.10.2+dfsg-1.debian.tar.xz
Files:
 ca46ffe011d3444f3150f0cf6e9ea5f8 2625 python optional pikepdf_1.10.2+dfsg-1.dsc
 07118a3f0b821ef28a78b4fec2244627 1523144 python optional 
pikepdf_1.10.2+dfsg.orig.tar.xz
 2cbe43e747ac6a02d3af36dada8aac2d 1922920 python optional 
pikepdf_1.10.2+dfsg-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAl5aicoACgkQaVt65L8G
YkAAQw//U9byRmQxDFXvIfcACsmNzSRxK6jpWATtpWrF0yTzdmr63o70bK/hJLod
yc1IBoYGsYMYXV/qCdC835+gEfAjYgqgE2OpjXQMYegsiqlojS22M3Y7Z/UMAd4p
2BrF0UFyEbI++kxAGP0Qm7Mw4ukcsPZapwivkkaleJPxVqs7ouZFlwkL69milJLu
pQ4sM3NAUnRH7Be+x3SqDUgvxhpnEb+0r9offQ42VdTvzrzgh3Z9WXonkfNavHU4
4odWTK6yjGbh+f52IsXakI+5gsu6eQhe8ofpEe18jEIL1fQZC29oFcyPgP0uCu35
x/wlVeLd37ynzQRx0uSB3cRTxmJ1RHt2apvg+g+JZtOFHXdwSkJOBGhP6wj9hbnn
6PJ3xMmzKSOAps+rA6yAM66N33NPLRSBFcKhuGGJ9/zv9/DdWuRCa5ZjsuJ2Aqwo
YoX52fRIFqpPAcMwrH/XwdRsFmKWrSnu3DpP4pTquEhMRjJtNCIBTkegOcOtfvFZ
VSkK7SA31R3jXw6damrvzqJ+990Y1uD2pK5HIYl9W9P4mKfmXHiCX/fBDex5XoiK
EnmlsS6LmPO4WSbEoI5kTHTdbqwVnUVdVH/bsVG26BAjQqftEVNkoCoQhJfMSc4B
zNYJ2JuLWdZ52iWA82puOJTeu6LyoUle3EiZPpPEYRC6qlgLRFc=
=zYpt
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Python-modules-team mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team

Reply via email to