Your message dated Wed, 11 Mar 2020 11:34:13 +0000 with message-id <e1jbzcr-0008k5...@fasolo.debian.org> and subject line Bug#952555: fixed in azure-uamqp-python 1.2.6-4 has caused the Debian Bug report #952555, regarding azure-uamqp-python: please make the build reproducible to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 952555: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=952555 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: azure-uamqp-python Version: 1.2.6-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: filesystem buildpath X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0] we noticed that azure-uamqp-python could not be built reproducibly. This is because it generated a .pyx file with the "#include" directives in a nondeterminstic order as well as included metadata in a ".c" file that embeded the absolute buildpath. However, it still embeds the current build path in the binary via assert-like logging messages ("LogError" IIRC). Patch attached for the former two issues. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `---- a/debian/patches/reproducible-build.patch 1969-12-31 16:00:00.000000000 -0800 --- b/debian/patches/reproducible-build.patch 2020-02-25 08:40:37.020019063 -0800 @@ -0,0 +1,24 @@ +Description: Make the build reproducible +Author: Chris Lamb <la...@debian.org> +Last-Update: 2020-02-25 + +--- azure-uamqp-python-1.2.6.orig/setup.py ++++ azure-uamqp-python-1.2.6/setup.py +@@ -45,7 +45,7 @@ cwd = os.path.abspath('.') + + # Headers + +-pxd_inc_dir = os.path.join(cwd, "src", "vendor", "inc") ++pxd_inc_dir = os.path.join(".", "src", "vendor", "inc") + sys.path.insert(0, pxd_inc_dir) + + include_dirs = [ +@@ -68,7 +68,7 @@ else: + + def create_cython_file(): + content_includes = "" +- for f in os.listdir("./src"): ++ for f in sorted(os.listdir("./src")): + if f.endswith(".pyx"): + print("Adding {}".format(f)) + content_includes += "include \"src/" + f + "\"\n" --- a/debian/patches/series 1969-12-31 16:00:00.000000000 -0800 --- b/debian/patches/series 2020-02-25 08:29:13.434683576 -0800 @@ -0,0 +1 @@ +reproducible-build.patch --- a/setup.py 2020-02-25 08:08:37.986925148 -0800 --- b/setup.py 2020-02-25 08:47:27.151166104 -0800 @@ -45,7 +45,7 @@ # Headers -pxd_inc_dir = os.path.join(cwd, "src", "vendor", "inc") +pxd_inc_dir = os.path.join(".", "src", "vendor", "inc") sys.path.insert(0, pxd_inc_dir) include_dirs = [ @@ -68,7 +68,7 @@ def create_cython_file(): content_includes = "" - for f in os.listdir("./src"): + for f in sorted(os.listdir("./src")): if f.endswith(".pyx"): print("Adding {}".format(f)) content_includes += "include \"src/" + f + "\"\n"
--- End Message ---
--- Begin Message ---Source: azure-uamqp-python Source-Version: 1.2.6-4 Done: Luca Boccassi <bl...@debian.org> We believe that the bug you reported is fixed in the latest version of azure-uamqp-python, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 952...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Luca Boccassi <bl...@debian.org> (supplier of updated azure-uamqp-python package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Wed, 11 Mar 2020 11:12:34 +0000 Source: azure-uamqp-python Architecture: source Version: 1.2.6-4 Distribution: unstable Urgency: medium Maintainer: Debian Python Modules Team <python-modules-t...@lists.alioth.debian.org> Changed-By: Luca Boccassi <bl...@debian.org> Closes: 952555 Changes: azure-uamqp-python (1.2.6-4) unstable; urgency=medium . * Enable hardening+all and reproducible=+fixfilepath (Closes: #952555) Checksums-Sha1: 7c89217984744f5ecb331900ae4e32ccd54dd890 1983 azure-uamqp-python_1.2.6-4.dsc 5d580ee36f88c50e495158d02d0d79031b6b6811 3048 azure-uamqp-python_1.2.6-4.debian.tar.xz bc74713931e77e5cf17b396458e82b753d831d09 7044 azure-uamqp-python_1.2.6-4_source.buildinfo Checksums-Sha256: 14b45a91b6ca68d6726f2082c6159e76fb8e6d60c9e8ece317e3d2c8ac420b73 1983 azure-uamqp-python_1.2.6-4.dsc 255a401ba89b574378348b3fe73358d8eb757814b3d58922f63c5602c8bde739 3048 azure-uamqp-python_1.2.6-4.debian.tar.xz d902c756905e4caec73bcad669645e8f71494ef5e62ee175b0a0eb8755c8b836 7044 azure-uamqp-python_1.2.6-4_source.buildinfo Files: 48c82087945e218cb62f2288047d958b 1983 python optional azure-uamqp-python_1.2.6-4.dsc 4fd7ec9009a11a30ea859cb0bf30f95f 3048 python optional azure-uamqp-python_1.2.6-4.debian.tar.xz 22c9ead318487f991aaa628ea068d383 7044 python optional azure-uamqp-python_1.2.6-4_source.buildinfo -----BEGIN PGP SIGNATURE----- iQFFBAEBCgAvFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAl5ox+MRHGJsdWNhQGRl Ymlhbi5vcmcACgkQSylmgFB4UWKypwgAp7EwwejZOjzPXX5c8TElprAzOtMBPNyR gy+tQH1rkBI5c3BMgbFxgnpNseEUJ4c1DIRPoElOEx2ZBm1oPj4K4lVS3AKRqg5E rG5g8jyvYSqrToRSFGbmhfs4eJ+IeP9ZbxIkzz8NSLNeHKieD14sH7mQAWvXxxML hQd/XOR5jm1WUSQRXooS6IEPNE2a5WHG8QxpQPAH87q20mgAVbolNCGmGSkzgl+r b+PH2rYbwIG7QL2/rI+3sNHy6d3KaXQjmCcrtyPc6KbD+9qCEfIAzGaAIXJLTjZh u0d8uzW1aGVNTsCndtz3oP5hpBKPcKlrRDusU+5+cSvQlg0ARydUOA== =dM1f -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
