On Sun, Jul 11, 2010 at 12:03:36AM +0900, Charles Plessy wrote: > In the hope of speeding up and strenghtening the processing of NEW I had a > look > at your package. The rationale is explained in the proposal in the following > wiki page: http://wiki.debian.org/CopyrightReview
Thanks for the review. > I found the two following problems: > > 1) files/okasha-docbook.css is not documented in your copyright file > (Copyright 2003 Tammy Fox, Garrett LeSage, and Red Hat, Inc. > Copyright 2005 Tommy Reynolds <[email protected]> > License: GPL ) Thanks for spotting that. I wonder though, how you spotted it, licensecheck only checked the python source files. > 2a) files/jquery.min.js is not the “preferrable form for modification”. > However, since your package is non-free, this is not a blocking problem. I don't understand this part. > 2b) files/jquery.min.js can be considered as an “embedded code copy”. It > causes > the following maintainance problem: in case a bug is found in this > library, > all the packages that would use a copy of this file would have to be > modified > in order to correct the bug. The solution is to depend on libjs-jquery and > use /usr/share/javascript/jquery/jquery.min.js from there. That's exactly what I've done, please build the package and look at the python-okasha-examples package. > In addition, I see that you chose the GPLv3+ for your packaging work; I do > not recommend it, since it is not compatible with “Waqf”: It may cause > headaches > if you would like to forward patches or files (manpages, …), that would be > GPLv3+ unless stated otherwise. Yes, this issue was raised by Jakub Wilk (who sponsored the package), and since I do not have any patches, I don't see a problem. Anyways, in case there are patches, I think I can put them under Waqf. (or GPL3+ or Waqf ?) -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7 _______________________________________________ Python-modules-team mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/python-modules-team
