Your message dated Tue, 27 May 2014 13:03:56 +0000
with message-id <[email protected]>
and subject line Bug#745756: fixed in python-django-registration 1.0+dfsg-1
has caused the Debian Bug report #745756,
regarding python-django-registration: Sends user_activated signal twice
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
745756: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745756
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python-django-registration
Version: 1.0-1
Severity: normal
Tags: patch
Dear Maintainer,
I am using python-django-registration in a couple of projects, and today I
encountered this problem [0]: when activating a user, django-registration
triggers the signal twice.
On stackoverflow there is an answer that links to this patch (done in a
bitbucket fork of the main repository, made by a user called Kami.) [1].
I'm not a packager, but I tried to do my best to obtain a patched debian
package, so that it would be easier work with it (for me and my colleagues).
I simply did:
* dget
* dch
* dpkg-source --commit
* debuild -us -uc
The resulting package installed well with dpkg and the problem was indeed
solved by Kami's patch.
So I'm reporting the bug and attaching the result of debdiff of the two
packages' dsc. If I can do something to help building a possible better patch,
feel free to tell me.
Kind regards,
Mark
[0]:
https://stackoverflow.com/questions/18789048/django-registration-user-activated-signal-sent-twice
[1]:
https://bitbucket.org/kami/django-registration/commits/6a0aff33bcf2cc24190916c74bc1b6822622d45a
-- System Information:
Debian Release: jessie/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.13-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages python-django-registration depends on:
ii libjs-sphinxdoc 1.2.2+dfsg-1
ii python 2.7.5-5
ii python-django 1.5.4-1
python-django-registration recommends no packages.
python-django-registration suggests no packages.
-- no debconf information
--
. ''`. | GPG Public Key : 0xCD542422 - Download it from http://is.gd/fOa7Vm
: :' : | GPG Fingerprint : 0823 A40D F31B 67A8 5621 AD32 E293 A2EB CD54 2422
`. `'` | Powered by Debian GNU/Linux, http://www.debian.org
`- | Try not. Do, or do not. There is no try. - Master Yoda, TESB.
diff -Nru python-django-registration-1.0/debian/changelog
python-django-registration-1.0/debian/changelog
--- python-django-registration-1.0/debian/changelog 2013-07-01
14:36:29.000000000 +0200
+++ python-django-registration-1.0/debian/changelog 2014-04-24
16:16:35.000000000 +0200
@@ -1,3 +1,10 @@
+python-django-registration (1.0-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Don't send user_activated signal twice.
+
+ -- Mark Caglienzi <[email protected]> Thu, 24 Apr 2014 16:15:47 +0200
+
python-django-registration (1.0-1) unstable; urgency=low
* New stable upstream.
diff -Nru
python-django-registration-1.0/debian/patches/send_signal_only_once_when_activating_user
python-django-registration-1.0/debian/patches/send_signal_only_once_when_activating_user
---
python-django-registration-1.0/debian/patches/send_signal_only_once_when_activating_user
1970-01-01 01:00:00.000000000 +0100
+++
python-django-registration-1.0/debian/patches/send_signal_only_once_when_activating_user
2014-04-24 16:20:53.000000000 +0200
@@ -0,0 +1,102 @@
+Description: Fixes double signal sending when activating user.
+ .
+ python-django-registration (1.0-1.1) UNRELEASED; urgency=medium
+ .
+ * Non-maintainer upload.
+ * Don't send user_activated signal twice.
+Author: Mark Caglienzi <[email protected]>
+Origin: other,
https://bitbucket.org/kami/django-registration/commits/6a0aff33bcf2cc24190916c74bc1b6822622d45a#chg-registration/views.py
+
+--- python-django-registration-1.0.orig/registration/views.py
++++ python-django-registration-1.0/registration/views.py
+@@ -7,7 +7,6 @@ from django.shortcuts import redirect
+ from django.views.generic.base import TemplateView
+ from django.views.generic.edit import FormView
+
+-from registration import signals
+ from registration.forms import RegistrationForm
+
+
+@@ -16,7 +15,7 @@ class _RequestPassingFormView(FormView):
+ A version of FormView which passes extra arguments to certain
+ methods, notably passing the HTTP request nearly everywhere, to
+ enable finer-grained processing.
+-
++
+ """
+ def get(self, request, *args, **kwargs):
+ # Pass request to get_form_class and get_form for per-request
+@@ -60,7 +59,7 @@ class _RequestPassingFormView(FormView):
+ class RegistrationView(_RequestPassingFormView):
+ """
+ Base class for user registration views.
+-
++
+ """
+ disallowed_url = 'registration_disallowed'
+ form_class = RegistrationForm
+@@ -72,7 +71,7 @@ class RegistrationView(_RequestPassingFo
+ """
+ Check that user signup is allowed before even bothering to
+ dispatch or do other processing.
+-
++
+ """
+ if not self.registration_allowed(request):
+ return redirect(self.disallowed_url)
+@@ -81,7 +80,7 @@ class RegistrationView(_RequestPassingFo
+ def form_valid(self, request, form):
+ new_user = self.register(request, **form.cleaned_data)
+ success_url = self.get_success_url(request, new_user)
+-
++
+ # success_url may be a simple string, or a tuple providing the
+ # full argument set for redirect(). Attempting to unpack it
+ # tells us which one it is.
+@@ -95,7 +94,7 @@ class RegistrationView(_RequestPassingFo
+ """
+ Override this to enable/disable user registration, either
+ globally or on a per-request basis.
+-
++
+ """
+ return True
+
+@@ -104,15 +103,15 @@ class RegistrationView(_RequestPassingFo
+ Implement user-registration logic here. Access to both the
+ request and the full cleaned_data of the registration form is
+ available here.
+-
++
+ """
+ raise NotImplementedError
+-
++
+
+ class ActivationView(TemplateView):
+ """
+ Base class for user activation views.
+-
++
+ """
+ http_method_names = ['get']
+ template_name = 'registration/activate.html'
+@@ -120,9 +119,6 @@ class ActivationView(TemplateView):
+ def get(self, request, *args, **kwargs):
+ activated_user = self.activate(request, *args, **kwargs)
+ if activated_user:
+- signals.user_activated.send(sender=self.__class__,
+- user=activated_user,
+- request=request)
+ success_url = self.get_success_url(request, activated_user)
+ try:
+ to, args, kwargs = success_url
+@@ -134,7 +130,7 @@ class ActivationView(TemplateView):
+ def activate(self, request, *args, **kwargs):
+ """
+ Implement account-activation logic here.
+-
++
+ """
+ raise NotImplementedError
+
diff -Nru python-django-registration-1.0/debian/patches/series
python-django-registration-1.0/debian/patches/series
--- python-django-registration-1.0/debian/patches/series 1970-01-01
01:00:00.000000000 +0100
+++ python-django-registration-1.0/debian/patches/series 2014-04-24
16:18:50.000000000 +0200
@@ -0,0 +1 @@
+send_signal_only_once_when_activating_user
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: python-django-registration
Source-Version: 1.0+dfsg-1
We believe that the bug you reported is fixed in the latest version of
python-django-registration, which is due to be installed in the Debian FTP
archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Raphaël Hertzog <[email protected]> (supplier of updated
python-django-registration package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 27 May 2014 14:23:29 +0200
Source: python-django-registration
Binary: python-django-registration
Architecture: source all
Version: 1.0+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Modules Team
<[email protected]>
Changed-By: Raphaël Hertzog <[email protected]>
Description:
python-django-registration - User-registration application for Django
Closes: 738931 745756
Changes:
python-django-registration (1.0+dfsg-1) unstable; urgency=medium
.
* Drop David Spreen from Uploaders. Closes: #738931
* Add send_signal_only_once_when_activating_user.patch submitted
by Mark Caglienzi <[email protected]>. Closes: #745756
* Update debian/copyright to follow new copyright format.
* Repack upstream tarball to drop docs/_build/ containing javascript
files without sources.
* Update Standards-Version to 3.9.5
* Update debhelper compat level to 9.
Checksums-Sha1:
c902c3c2bae1a455187ae0cfea48e6ee20c16a08 2082
python-django-registration_1.0+dfsg-1.dsc
b0c46ee6731b9ec9cb87e4f943aa8f69a0ad834c 60658
python-django-registration_1.0+dfsg.orig.tar.gz
5bbd9e7573b16809d038ad1469da118b01850f25 5796
python-django-registration_1.0+dfsg-1.debian.tar.xz
c9af78fd6b4e797d08a6ffd02b0adb6f879e57bc 74348
python-django-registration_1.0+dfsg-1_all.deb
Checksums-Sha256:
f5bd72c7652434bda3625f2d675aab0597cfd85ab2308db8f089af7c029abdb9 2082
python-django-registration_1.0+dfsg-1.dsc
9d08689be81afae92895d841dab83146ecf8dbe37957c5fb2fa1b45d9f8844cd 60658
python-django-registration_1.0+dfsg.orig.tar.gz
d0c8c9ac26e0038e1579c42e1b503b804b9f73e0e85fbed37b5c32d08105358c 5796
python-django-registration_1.0+dfsg-1.debian.tar.xz
73a62fc37ee64d4dd99c8e021b2b72ef6152d0213f566421fca6a687591ee1be 74348
python-django-registration_1.0+dfsg-1_all.deb
Files:
941aa5fff7e2c32651d994bf5c9b406b 74348 python optional
python-django-registration_1.0+dfsg-1_all.deb
7fed541f5c51d5f636edaf66701b3bf5 2082 python optional
python-django-registration_1.0+dfsg-1.dsc
458d0e3026e3ab72fc85b63ce78c5e78 60658 python optional
python-django-registration_1.0+dfsg.orig.tar.gz
e77001fa1c7a931a8e75888aff0af1a1 5796 python optional
python-django-registration_1.0+dfsg-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Signed by Raphael Hertzog
iQEcBAEBCAAGBQJThIw1AAoJEAOIHavrwpq56egH/RSn6pmSHP4q6YNs5z5L0CGH
99DGXpJzmHLU/zVwFO/iuTfVMEdi3fZWDRp4h8nu6cJVeePHB1+Usrj3BQjFr7VR
TaMe/vASOj7thw7BxVSpgSbq048qZnkqmsBdUDvBwL706uvRMdK3HuDvfzRMqt6S
Ug7zwWMnARUlrb9zsQUmOV6IMaSKCAKrWDWI6Qo2AblsoLZkQMqUJR00x1LChtw3
LC+J6V7ZDS1ltnvrI96e0jXibP9FE1TuIr4FB5lY/I0rZf4Y/LwRu7hvDFtsut8/
+wjIWgUnF71AgOdKZ/ojGaIsNfE0Qlypc8Zev9XAT8KHKMC1BVCCabRFoGx2ce4=
=Ot9U
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Python-modules-team mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team
