Your message dated Sun, 26 Oct 2014 00:49:24 +0000
with message-id <[email protected]>
and subject line Bug#748903: fixed in python-tornado 3.2.2-1.1
has caused the Debian Bug report #748903,
regarding python-tornado: FTBFS on hurd-i386
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
748903: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748903
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: python-tornado
Version: 3.2.0-1
Severity: important
Tags: patch
User: [email protected]
Usertags: hurd

Hi,

Currently python-tornado fails to build from source on GNU/Hurd due to
two failed tests: test_unix_socket and test_unix_socket_bad_request.
The attached patch fixes these failures by not using the options 
SO_REUSEADDR for setsockopt in tornado/netutil.py and SO_ERROR for
getsockopt in tornado/iostream.py since they are not yet implemented.

With the patch all 739 tests, with 76 skipped, in the testsuite
pass and they are a requisite for the package to build.

Thanks!

--- a/tornado_netutil.py	2014-01-09 03:57:56.000000000 +0100
+++ b/tornado/netutil.py	2014-05-21 17:38:42.000000000 +0200
@@ -20,6 +20,7 @@
 
 import errno
 import os
+import sys
 import socket
 import ssl
 import stat
@@ -119,7 +120,8 @@
         """
         sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
         set_close_exec(sock.fileno())
-        sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
+        if sys.platform != 'gnu0':
+            sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
         sock.setblocking(0)
         try:
             st = os.stat(file)
--- a/tornado/iostream.py	2014-01-04 17:51:39.000000000 +0100
+++ b/tornado/iostream.py	2014-05-21 18:42:37.000000000 +0200
@@ -687,9 +687,12 @@
         self.socket = None
 
     def get_fd_error(self):
-        errno = self.socket.getsockopt(socket.SOL_SOCKET,
-                                       socket.SO_ERROR)
-        return socket.error(errno, os.strerror(errno))
+        if sys.platform != 'gnu0':
+            errno = self.socket.getsockopt(socket.SOL_SOCKET,
+                                           socket.SO_ERROR)
+            return socket.error(errno, os.strerror(errno))
+        else:
+            return None
 
     def read_from_fd(self):
         try:
@@ -748,7 +751,10 @@
         self._add_io_state(self.io_loop.WRITE)
 
     def _handle_connect(self):
-        err = self.socket.getsockopt(socket.SOL_SOCKET, socket.SO_ERROR)
+        if sys.platform != 'gnu0':
+            err = self.socket.getsockopt(socket.SOL_SOCKET, socket.SO_ERROR)
+        else:
+            err = 0
         if err != 0:
             self.error = socket.error(err, os.strerror(err))
             # IOLoop implementations may vary: some of them return

--- End Message ---
--- Begin Message ---
Source: python-tornado
Source-Version: 3.2.2-1.1

We believe that the bug you reported is fixed in the latest version of
python-tornado, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Thibault <[email protected]> (supplier of updated python-tornado 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 25 Oct 2014 21:14:45 +0200
Source: python-tornado
Binary: python-tornado python3-tornado
Architecture: source amd64
Version: 3.2.2-1.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Modules Team 
<[email protected]>
Changed-By: Samuel Thibault <[email protected]>
Description:
 python-tornado - scalable, non-blocking web server and tools
 python3-tornado - scalable, non-blocking web server and tools - Python 3 
package
Closes: 748903
Changes:
 python-tornado (3.2.2-1.1) unstable; urgency=medium
 .
   * Non-Maintainer Upload.
   * patches/sockopt.patch: New patch to ignore ENOPROTOOPT errors from
     SO_REUSEADDR or SO_ERROR on AF_UNIX sockets, for systems which do not
     implement them there. Thanks Svante Signell for the patch. (Closes: 
#748903)
Checksums-Sha1:
 de5e5383f5b24090ea32a7d84a43d62753df6439 2248 python-tornado_3.2.2-1.1.dsc
 2d3c390630692c6d46b4bddede783c54f837aa80 14784 
python-tornado_3.2.2-1.1.debian.tar.xz
 82829774792024b06be8316937d8aab8ed903fa7 228142 
python-tornado_3.2.2-1.1_amd64.deb
 ea8d54fbf0c93aff9e9e9aa679b2511a10f2bee7 212142 
python3-tornado_3.2.2-1.1_amd64.deb
Checksums-Sha256:
 bf5858a00ee13938ed7d4d99ff289538472d463cdbef46e28609b5d524a3196c 2248 
python-tornado_3.2.2-1.1.dsc
 2297f031823d69a78137fa6c07c8a7580c548f0ebeb9722e985739db03e12e55 14784 
python-tornado_3.2.2-1.1.debian.tar.xz
 6179e09ba615916aa3b13120cb4019e09eae36832ff2fb852fe3d4aa64bcefaa 228142 
python-tornado_3.2.2-1.1_amd64.deb
 6e0cf012df68a18e06ee0bf12fd8ab148f0261e77fa1e07b8e5dde828e79e67f 212142 
python3-tornado_3.2.2-1.1_amd64.deb
Files:
 36f83b568ad085ebd149e6096f6a4396 2248 web optional python-tornado_3.2.2-1.1.dsc
 91da44915d1f99556d9364c618c28a8a 14784 web optional 
python-tornado_3.2.2-1.1.debian.tar.xz
 e309bbf7e904d5a18e018422d89cfaa0 228142 web optional 
python-tornado_3.2.2-1.1_amd64.deb
 954d5c9134a2b984b630bca3d931b7c5 212142 web optional 
python3-tornado_3.2.2-1.1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJUTELaAAoJEBH0lP5vGG7NIpsQAIKBG/rwiMJAT3W9KWE3lhO1
8p9+oM9rqt1raFORqi7jVRs4/aRiIoF96IHHqFB7g9EWE1v4HZ59ekm/6cnIjA5V
aceYnJW3XBFI27CGlZvk3B7C3Gkv/PibHzUt9VR8o2OaTmkqviEtDYC1DslxBsvo
+bYUXrp0T1iHScH+7hd1lDr3O5mIgHjHDm+2644ywuJjW9zO9ri/Uyt645Q2lySO
eEimZq4dOZFZls9WppEhd8vbvp472RjVTDnfZxqVOcs81nlSY0lqlFs+QA4e4DHo
BGr/VQRz7PsPsLoa2KC7QFaJovHjQl4KQJYCcECW/S1Eqz6VPl+hO0F+rasaX8PX
JYAW+DLMfB0V6COtg3ziXGSUPlSyfnFmeDqZxnMgoUUiVCAN89q/J4sS5vTR8tfS
WXdSfumtKIvmsHx63wt1m/NyrN6+2zlxHuhPZOr96b3rNW9gkQBAMxs+j3qU0r12
hYBaPqEcN4hYOqQqV/joj1EJCgGBi5FbP6CZsc2zbk6FSqBLIohYGj2Ccjnwo8eB
BxXH4z2RcTuohSlS8U7Ur20vUt12xJJ0KKGNr4V1NX+edfW6vkKSJRN8DXlX9yAi
pFLFdltqcnEIXM3UTzmfXxDpNvBXYBlW5TPR1W8+vR3whNxYYaSYMs9Y5BOV90/I
mTHvkc+26Tzgia1RHBfm
=vXKE
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Python-modules-team mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team

Reply via email to