Your message dated Thu, 09 Mar 2017 03:04:25 +0000
with message-id <[email protected]>
and subject line Bug#857171: fixed in python-git 2.1.1-2
has caused the Debian Bug report #857171,
regarding import of git can cause import failures of unrelated modules due to 
undefined variable
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
857171: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857171
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python-git
Version: 2.1.0-1
Severity: critical
Tags: upstream patch

$> docker run -it --rm debian:stretch
root@7f7cfee9f6fa:/# apt-get update -qqq; apt-get install -qqq -y python-h5py 
python-git
debconf: delaying package configuration, since apt-utils is not installed
(Reading database ... 6415 files and directories currently installed.)
Preparing to unpack .../perl-base_5.24.1-1_amd64.deb ...
...
done.
root@7f7cfee9f6fa:/# python -c 'import git; import h5py'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python2.7/dist-packages/h5py/__init__.py", line 60, in <module>
    from .tests import run_tests
  File "/usr/lib/python2.7/dist-packages/h5py/tests/__init__.py", line 15, in 
<module>
    from . import old, hl
  File "/usr/lib/python2.7/dist-packages/h5py/tests/old/__init__.py", line 4, 
in <module>
    from . import ( test_attrs,
  File "/usr/lib/python2.7/dist-packages/h5py/tests/old/test_group.py", line 
41, in <module>
    fsencode(u"α")
  File "/usr/lib/python2.7/dist-packages/h5py/_hl/compat.py", line 68, in 
fsencode
    return filename.encode(encoding, errors)
  File "/usr/lib/python2.7/dist-packages/git/compat.py", line 180, in 
surrogateescape_handler
    decoded = replace_surrogate_encode(mystring)
  File "/usr/lib/python2.7/dist-packages/git/compat.py", line 207, in 
replace_surrogate_encode
    raise exc
NameError: global name 'exc' is not defined


Issue was reported and fixed upstream through a sequence of two PRs (heh) which
are compressed into a single small patch attached to this report.  This issue
already gave me notable pain, so quick update in stretch would be
appreciated!

here is a proof of it working:

root@7f7cfee9f6fa:/usr/lib/python2.7/dist-packages# curl 
http://www.onerussian.com/tmp/exc_exception.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1338  100  1338    0     0   210k      0 --:--:-- --:--:-- --:--:--  217k
patching file git/compat.py
root@7f7cfee9f6fa:/usr/lib/python2.7/dist-packages# cd /tmp
root@7f7cfee9f6fa:/tmp# python -c 'import git; import h5py'
root@7f7cfee9f6fa:/tmp# 


-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (900, 'testing'), (600, 'unstable'), (300, 'experimental'), (100, 
'unstable-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages python-git depends on:
ii  git [git-core]  1:2.11.0-2
ii  git-core        1:2.11.0-2
ii  python-gitdb    2.0.0-2
pn  python:any      <none>

python-git recommends no packages.

Versions of packages python-git suggests:
ii  python-git-doc  2.1.0-1
ii  python-smmap    2.0.1-1

-- debconf-show failed
From: Yaroslav Halchenko <[email protected]>
Subject: Pass exc value to be re-raised 

Origin: https://github.com/gitpython-developers/GitPython/pull/598
        https://github.com/gitpython-developers/GitPython/pull/603
Bug-Debian: http://bugs.debian.org/
Bug-Ubuntu: https://launchpad.net/bugs/
Applied-Upstream: 
https://github.com/gitpython-developers/GitPython/commit/9ce2a4b235d2ebc38c3e081c1036e39bde9be036
Last-Update: 2017-03-08

diff --git a/git/compat.py b/git/compat.py
index a2403d6..b804585 100644
--- a/git/compat.py
+++ b/git/compat.py
@@ -177,7 +177,7 @@ def surrogateescape_handler(exc):
             # exception anyway after this function is called, even though I 
think
             # it's doing what it should. It seems that the strict encoder is 
called
             # to encode the unicode string that this function returns ...
-            decoded = replace_surrogate_encode(mystring)
+            decoded = replace_surrogate_encode(mystring, exc)
         else:
             raise exc
     except NotASurrogateError:
@@ -189,7 +189,7 @@ class NotASurrogateError(Exception):
     pass
 
 
-def replace_surrogate_encode(mystring):
+def replace_surrogate_encode(mystring, exc):
     """
     Returns a (unicode) string, not the more logical bytes, because the codecs
     register_error functionality expects this.

--- End Message ---
--- Begin Message ---
Source: python-git
Source-Version: 2.1.1-2

We believe that the bug you reported is fixed in the latest version of
python-git, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
TANIGUCHI Takaki <[email protected]> (supplier of updated python-git package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 09 Mar 2017 11:37:28 +0900
Source: python-git
Binary: python-git python3-git python-git-doc
Architecture: source all
Version: 2.1.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Modules Team 
<[email protected]>
Changed-By: TANIGUCHI Takaki <[email protected]>
Description:
 python-git - Python library to interact with Git repositories - Python 2.7
 python-git-doc - Python library to interact with Git repositories - docs
 python3-git - Python library to interact with Git repositories - Python 3.x
Closes: 857171
Changes:
 python-git (2.1.1-2) unstable; urgency=medium
 .
   * debian/patches/exe_exception.patch: Fix "import of git can cause import
     failures of unrelated modules due to undefined variable" (Closes: #857171)
Checksums-Sha1:
 e2e15c71e7d346974244737a829a2a1b5a326e9b 2443 python-git_2.1.1-2.dsc
 183a5c553d5b97b0d7081cc1fc176d2e224a58b3 6340 python-git_2.1.1-2.debian.tar.xz
 a45983c05b8f3ad313bf15e679f3ebe6385d7542 127302 python-git-doc_2.1.1-2_all.deb
 901115e9736b85549350b939d583ade49e8fc968 298498 python-git_2.1.1-2_all.deb
 d79d7a036428d271416d3b0e55aad33652f0bb19 8474 
python-git_2.1.1-2_amd64.buildinfo
 c75b431821865af6aa4c8a23b2b278e5b346f4d8 298142 python3-git_2.1.1-2_all.deb
Checksums-Sha256:
 9d545e31c0fe53ce0f368da9803e0455f3d07239aff4d7a5520c7d4475e3ee75 2443 
python-git_2.1.1-2.dsc
 7541a6ee3503e92f9643cbb035723e73fbfe7b282348463eb1678f003bdce5fc 6340 
python-git_2.1.1-2.debian.tar.xz
 f00f9351c66a925ef928be5d836a99b8b6e3f11d709c86a2f673d46c9938188b 127302 
python-git-doc_2.1.1-2_all.deb
 497d5406946a372f77d0aff657ebdaa1506939445f5f75ca7f09db1610f2d13b 298498 
python-git_2.1.1-2_all.deb
 122920ebe0f9d38b0267b6089bea963ec673c11c74b0926e540ccefeade47e91 8474 
python-git_2.1.1-2_amd64.buildinfo
 4c7c79055b1f8f03dc09fc97995c7dfdd70cc9ef2a369d457b4971d96210ae53 298142 
python3-git_2.1.1-2_all.deb
Files:
 6c6a6ea57b5397e092d6b0f3cc01343f 2443 python optional python-git_2.1.1-2.dsc
 d460fdf2ae50d48c15037897e12d9692 6340 python optional 
python-git_2.1.1-2.debian.tar.xz
 9449a1adbd58da3b70d7eaeca26e91bb 127302 doc optional 
python-git-doc_2.1.1-2_all.deb
 7aa9b912b21180a8a07ea13ff68fc467 298498 python optional 
python-git_2.1.1-2_all.deb
 2e635690f8f726894b77a6048b08fb5d 8474 python optional 
python-git_2.1.1-2_amd64.buildinfo
 daee2545c14aa557b9c4feae11b3a60d 298142 python optional 
python3-git_2.1.1-2_all.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE0kq/0SfNJVahPGx5zBSfbCil4lcFAljAwCYACgkQzBSfbCil
4lfSbg/7BeqPWT8aY1aWfrUlhZjluq7XqVxf0IQtkTP7YkaUftY5qJOXS8JY7arZ
9goc2nzIcMeWxD2JkiXIxc8FwGWNzkADOe2Bm+EodtZT0/sVyRQX12pVSXdDSI+E
6nRuKEFn4WP94hzs+0CFmjedlY5r9EliGwxgJV7+937XjSBcrwJadVLD4Qn5h6PO
WiKYKqRpKM71uzuIq3wq752G7qlXDx4SyLCVk6Iwv0aPXfAdklxyEJkhxiSIPJQ+
h1YgYF/zkxO1ZVKtlWgUmWbMtyXWBDLHi9OQYDkdRnNst8SCnslVRhWqIRxHykfj
/n68YxZ6nEoxjqSEmb59edMjN3Q8/8TUUtwjAajXuVh77o8RaAnPY2fscw9P7KT/
QEA7ZR5mJ6X/oWb8kQ/Lj6SX5J6RMlzCRKC/xP3MZJ68RIz/0Bsg9oYjy3GG0LWb
UGePLSMGpmmM7Gw+vJ/bPbAxvCGZbMi83CB3+5PD4603UIRlZOkrwqm6g9ZMjc7f
42wLg/3Rk1cPhZhepjPvBEodMUS8QFX6wh83HJDZRlkR1oKMdK+lNaAWBBbaxRZY
Ymyd4UzOXX5hGfzaEXEwNyy/B6mSRF8iGxr+LLSuhZ5xmdVpqer90Ccufg9WY1cX
FQfa+8/w1yIhNCWhrg1H9kSazSziIo9D7jvuBHNGq4wRGhRD4yE=
=Gb+x
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Python-modules-team mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team

Reply via email to