That's great, thanks.
Could you please consider one follow-on patch that improves some of the
warning names, after feedback from tmarek? It would of course be good to
get these in before anyone starts counting on the existing names. (This is
also now in my bitbucket repo.)
Regards,
Martin
diff -r 0986f4b8caef -r ed3634da2616 checkers/classes.py
--- a/checkers/classes.py Tue Sep 18 14:05:00 2012 +1000
+++ b/checkers/classes.py Thu Sep 20 17:44:00 2012 +1000
@@ -43,8 +43,8 @@
compatibility for an unexpected reason. Please report this
kind \
if you don\'t make sense of it.'),
- 'E0202': ('An attribute affected in %s line %s hide this method',
- 'method-hidden',
+ 'E0202': ('An attribute affected in %s line %s shadows this method',
+ 'method-shadowed',
'Used when a class defines a method which is hidden by an '
'instance attribute from an ancestor class or set by some '
'client code.'),
@@ -109,7 +109,7 @@
'Used when a method signature is different than in the \
implemented interface or in an overridden method.'),
'W0223': ('Method %r is abstract in class %r but is not overridden',
- 'abstract-method',
+ 'abstract-unimplemented',
'Used when an abstract method (i.e. raise
NotImplementedError) is \
not overridden in concrete class.'
),
@@ -128,7 +128,7 @@
'Used when a class has no __init__ method, neither its
parent \
classes.'),
'W0233': ('__init__ method from a non direct base class %r is called',
- 'non-parent-init-called',
+ 'non-base-init-called',
'Used when an __init__ method is called on a class which is
not \
in the direct ancestors for the analysed class.'),
diff -r 0986f4b8caef -r ed3634da2616 checkers/exceptions.py
--- a/checkers/exceptions.py Tue Sep 18 14:05:00 2012 +1000
+++ b/checkers/exceptions.py Thu Sep 20 17:44:00 2012 +1000
@@ -59,7 +59,7 @@
'Used when an except catches a too general exception, \
possibly burying unrelated errors.'),
'W0704': ('Except doesn\'t do anything',
- 'pointless-except',
+ 'empty-except',
'Used when an except clause does nothing but "pass" and
there is\
no "else" clause.'),
'W0710': ('Exception doesn\'t inherit from standard "Exception" class',
diff -r 0986f4b8caef -r ed3634da2616 checkers/logging.py
--- a/checkers/logging.py Tue Sep 18 14:05:00 2012 +1000
+++ b/checkers/logging.py Thu Sep 20 17:44:00 2012 +1000
@@ -1,4 +1,4 @@
-# Copyright (c) 2009-2010 Google, Inc.
+# Copyright (c) 2009-2012 Google, Inc.
# This program is free software; you can redistribute it and/or modify it
under
# the terms of the GNU General Public License as published by the Free
Software
# Foundation; either version 2 of the License, or (at your option) any
later
@@ -22,7 +22,7 @@
MSGS = {
'W1201': ('Specify string format arguments as logging function
parameters',
- 'logging-not-lazy',
+ 'logging-eager-formatting',
'Used when a logging statement has a call form of '
'"logging.<logging method>(format_string %
(format_args...))". '
'Such calls should leave string interpolation to the logging '
diff -r 0986f4b8caef -r ed3634da2616 checkers/newstyle.py
--- a/checkers/newstyle.py Tue Sep 18 14:05:00 2012 +1000
+++ b/checkers/newstyle.py Thu Sep 20 17:44:00 2012 +1000
@@ -24,7 +24,7 @@
MSGS = {
'E1001': ('Use of __slots__ on an old style class',
- 'slots-on-old-class',
+ 'slots-on-old-style-class',
'Used when an old style class uses the __slots__
attribute.'),
'E1002': ('Use of super on an old style class',
'super-on-old-class',
_______________________________________________
Python-Projects mailing list
Python-Projects@lists.logilab.org
http://lists.logilab.org/mailman/listinfo/python-projects
